From: Junio C Hamano <gitster@pobox.com>
To: Thomas Ackermann <th.acker66@arcor.de>
Cc: git@vger.kernel.org
Subject: Re: [Patch 1/5] Fix some asciidoc layout problems
Date: Sat, 06 Oct 2012 11:39:13 -0700 [thread overview]
Message-ID: <7vfw5rqwby.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <244418682.269701.1349538839518.JavaMail.ngmail@webmail08.arcor-online.net> (Thomas Ackermann's message of "Sat, 6 Oct 2012 17:53:59 +0200 (CEST)")
Thomas Ackermann <th.acker66@arcor.de> writes:
> Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
> ---
> Documentation/git-bisect-lk2009.txt | 12 ++++++------
> Documentation/git-fetch-pack.txt | 5 ++++-
> 2 files changed, 10 insertions(+), 7 deletions(-)
You didn't say what "layout problem" you are fixing, or what the
approach you took to "fix" it. From the patch, I can guess that the
latter is to lengthen the lines that surround the displayed examples,
but as far as I know and can tell, the existing ones are long enough
so I cannot tell why you needed such a change to the source in the
first place.
A better explanation, please?
The synopsis section of git-fetch-pack manual is a long single line
which is unsightly. A fix to that issue is indeed needed. Please
make a separate patch only for that issue. Is git-fetch-pack the
only one whose synopsis section is overlong, by the way?
Thanks.
>
> diff --git a/Documentation/git-bisect-lk2009.txt b/Documentation/git-bisect-lk2009.txt
> index 8a2ba37..99bdb46 100644
> --- a/Documentation/git-bisect-lk2009.txt
> +++ b/Documentation/git-bisect-lk2009.txt
> @@ -248,7 +248,7 @@ Bisecting: 5480 revisions left to test after this (roughly 13 steps)
> And after a few more steps like that, "git bisect" will eventually
> find a first bad commit:
>
> --------------
> +------------------------------------------------------------------------------------------------------------
> $ git bisect bad
> 2ddcca36c8bcfa251724fe342c8327451988be0d is the first bad commit
> commit 2ddcca36c8bcfa251724fe342c8327451988be0d
> @@ -257,8 +257,8 @@ Date: Sat May 3 11:59:44 2008 -0700
>
> Linux 2.6.26-rc1
>
> -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M Makefile
> --------------
> +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M Makefile
> +------------------------------------------------------------------------------------------------------------
>
> At this point we can see what the commit does, check it out (if it's
> not already checked out) or tinker with it, for example:
> @@ -305,7 +305,7 @@ to launch a script or command at each bisection step to know if the
> current commit is "good" or "bad". To do that, we use the "git bisect
> run" command. For example:
>
> --------------
> +------------------------------------------------------------------------------------------------------------
> $ git bisect start v2.6.27 v2.6.25
> Bisecting: 10928 revisions left to test after this (roughly 14 steps)
> [2ec65f8b89ea003c27ff7723525a2ee335a2b393] x86: clean up using max_low_pfn on 32-bit
> @@ -331,9 +331,9 @@ Date: Sat May 3 11:59:44 2008 -0700
>
> Linux 2.6.26-rc1
>
> -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M Makefile
> +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M Makefile
> bisect run success
> --------------
> +------------------------------------------------------------------------------------------------------------
>
> In this example, we passed "grep '^SUBLEVEL = 25' Makefile" as
> parameter to "git bisect run". This means that at each step, the grep
> diff --git a/Documentation/git-fetch-pack.txt b/Documentation/git-fetch-pack.txt
> index 474fa30..12cd8a2 100644
> --- a/Documentation/git-fetch-pack.txt
> +++ b/Documentation/git-fetch-pack.txt
> @@ -9,7 +9,10 @@ git-fetch-pack - Receive missing objects from another repository
> SYNOPSIS
> --------
> [verse]
> -'git fetch-pack' [--all] [--quiet|-q] [--keep|-k] [--thin] [--include-tag] [--upload-pack=<git-upload-pack>] [--depth=<n>] [--no-progress] [-v] [<host>:]<directory> [<refs>...]
> +'git fetch-pack' [--all] [--quiet|-q] [--keep|-k] [--thin] [--include-tag]
> + [--upload-pack=<git-upload-pack>]
> + [--depth=<n>] [--no-progress]
> + [-v] [<host>:]<directory> [<refs>...]
>
> DESCRIPTION
> -----------
next prev parent reply other threads:[~2012-10-06 18:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 15:51 [Patch 0/5] Create single PDF for all HTML files Thomas Ackermann
2012-10-06 15:53 ` [Patch 1/5] Fix some asciidoc layout problems Thomas Ackermann
2012-10-06 18:39 ` Junio C Hamano [this message]
2012-10-06 19:10 ` Jeff King
2012-10-07 8:01 ` Aw: " Thomas Ackermann
2012-10-06 15:55 ` [Patch 2/5] Create html documents for all files in Documentation/technical Thomas Ackermann
2012-10-06 18:45 ` Philip Oakley
2012-10-06 15:55 ` [Patch 3/5] Create html documents for all files in Documentation/RelNotes Thomas Ackermann
2012-10-06 18:48 ` Philip Oakley
2012-10-06 19:21 ` Jeff King
2012-10-07 20:53 ` Junio C Hamano
2012-10-15 11:48 ` Michael J Gruber
2012-10-15 20:49 ` Junio C Hamano
2012-10-06 15:57 ` [Patch 4/5] Create html documents for all files in Documentation/howto Thomas Ackermann
2012-10-06 15:58 ` [Patch 5/5] Create pdf from all html files Thomas Ackermann
2012-10-06 19:11 ` Jeff King
2012-10-06 19:32 ` [Patch 0/5] Create single PDF for all HTML files Jeff King
2012-10-07 20:54 ` Junio C Hamano
2012-10-07 8:14 ` Aw: " Thomas Ackermann
2012-10-07 22:52 ` Jeff King
2012-10-15 11:55 ` Michael J Gruber
2012-10-15 17:42 ` Jeff King
2012-10-08 22:53 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfw5rqwby.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=th.acker66@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).