From: Junio C Hamano <gitster@pobox.com>
To: "Ondřej Bílka" <neleai@seznam.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Random typofixes.
Date: Mon, 22 Jul 2013 16:06:02 -0700 [thread overview]
Message-ID: <7vfvv69ov9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130722210223.GA26492@domone.kolej.mff.cuni.cz> ("Ondřej Bílka"'s message of "Mon, 22 Jul 2013 23:02:23 +0200")
Ondřej Bílka <neleai@seznam.cz> writes:
> Hi, this is refactored version of my previous typofix patch. I avoid
> here controversional fixes.
> I am writing a https://github.com/neleai/stylepp tool to handle
> various style issues.
>
> To simplify review I wrote a utility:
>
> stylepp_strip_diff
>
> That takes a patch file, strips surrounding lines and prints intervals
> that were changes.
>
> Its output is below and patch follows:
> ...
Next time please omit all of the above. We can test-apply and then
run "diff --word-diff" to get a comparison that is much easier to
read.
> diff --git a/Documentation/RelNotes/1.8.2.txt b/Documentation/RelNotes/1.8.2.txt
> index fc606ae..5da2a9d 100644
> --- a/Documentation/RelNotes/1.8.2.txt
> +++ b/Documentation/RelNotes/1.8.2.txt
> @@ -67,7 +67,7 @@ UI, Workflows & Features
> * The completion script (in contrib/completion) used to let the
> default completer to suggest pathnames, which gave too many
> irrelevant choices (e.g. "git add" would not want to add an
> - unmodified path). It learnt to use a more git-aware logic to
> + unmodified path). It learned to use a more git-aware logic to
I'd leave the original as-is (cf. http://bit.ly/1bH8OlT).
> diff --git a/Documentation/howto/revert-branch-rebase.txt b/Documentation/howto/revert-branch-rebase.txt
> index 84dd839..29a7cfa 100644
> --- a/Documentation/howto/revert-branch-rebase.txt
> +++ b/Documentation/howto/revert-branch-rebase.txt
> @@ -12,7 +12,7 @@ How to revert an existing commit
> ================================
>
> One of the changes I pulled into the 'master' branch turns out to
> -break building Git with GCC 2.95. While they were well intentioned
> +break building Git with GCC 2.95. While they were well intended
Likewise (cf. http://bit.ly/12HZx4x), but it needs a hyphen between
these two words, which I'll add before applying the patch.
> diff --git a/Documentation/technical/racy-git.txt b/Documentation/technical/racy-git.txt
> index f716d6d..242a044 100644
> --- a/Documentation/technical/racy-git.txt
> +++ b/Documentation/technical/racy-git.txt
> @@ -46,7 +46,7 @@ because in-core timestamps can have finer granularity than
> on-disk timestamps, resulting in meaningless changes when an
> inode is evicted from the inode cache. See commit 8ce13b0
> of git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
> -([PATCH] Sync in core time granuality with filesystems,
> +([PATCH] Sync in core time granularity with filesystems,
> 2005-01-04).
This is dubious, as it is referring to what is already cast in
stone, but I'll apply the update as-is, with the rest of the patch.
Thanks. It really shows we cannot spell X-<.
prev parent reply other threads:[~2013-07-22 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:02 [PATCH] Random typofixes Ondřej Bílka
2013-07-22 23:06 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfvv69ov9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=neleai@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).