From: Junio C Hamano <gitster@pobox.com>
To: Jamis Buck <jamis@37signals.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Honor git-reset -q by silencing progress updates.
Date: Sat, 31 May 2008 15:43:59 -0700 [thread overview]
Message-ID: <7vej7idrgw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <32206B67-D97A-459E-BA48-D3B343D775F3@37signals.com> (Jamis Buck's message of "Sat, 31 May 2008 15:41:54 -0600")
Jamis Buck <jamis@37signals.com> writes:
> --Apple-Mail-10--112802933
> Content-Type: text/plain;
> charset=US-ASCII;
> format=flowed;
> delsp=yes
> Content-Transfer-Encoding: 7bit
Please do not do unnecessary S/MIME nor format=flawed. It makes reviewing
and application of the patches inconvenient.
>
> When running git-reset in a non-interactive setting, the -q switch
> works for everything except the progress updates. This patch attempts
> to extend the application of -q to suppress that, too.
> ---
> builtin-reset.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/builtin-reset.c b/builtin-reset.c
> index e32ddd9..3810f6d 100644
> --- a/builtin-reset.c
> +++ b/builtin-reset.c
> @@ -49,13 +49,14 @@ static inline int is_merge(void)
> return !access(git_path("MERGE_HEAD"), F_OK);
> }
>
> -static int reset_index_file(const unsigned char *sha1, int
> is_hard_reset)
> +static int reset_index_file(const unsigned char *sha1, int
> is_hard_reset, int quiet)
> {
prev parent reply other threads:[~2008-05-31 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 21:41 [PATCH] Honor git-reset -q by silencing progress updates Jamis Buck
2008-05-31 22:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vej7idrgw.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jamis@37signals.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).