From: Junio C Hamano <gitster@pobox.com>
To: John Szakmeister <john@szakmeister.net>
Cc: Sebastian Schuberth <sschuberth@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
msysGit Mailinglist <msysgit@googlegroups.com>,
Thomas Braun <thomas.braun@virtuell-zuhause.de>,
Pat Thoyts <patthoyts@users.sourceforge.net>
Subject: Re: [PATCH] Do not call built-in aliases from scripts
Date: Thu, 27 Jun 2013 11:10:01 -0700 [thread overview]
Message-ID: <7vehbns9vq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vmwqbsa3u.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 27 Jun 2013 11:05:09 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> John Szakmeister <john@szakmeister.net> writes:
>
>> On Thu, Jun 27, 2013 at 1:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> [snip]
>>>> diff --git a/git-am.sh b/git-am.sh
>>>> index 9f44509..ad67194 100755
>>>> --- a/git-am.sh
>>>> +++ b/git-am.sh
>>>> @@ -16,8 +16,8 @@ s,signoff add a Signed-off-by line to the commit message
>>>> u,utf8 recode into utf8 (default)
>>>> k,keep pass -k flag to git-mailinfo
>>>> keep-non-patch pass -b flag to git-mailinfo
>>>> -keep-cr pass --keep-cr flag to git-mailsplit for mbox format
>>>> -no-keep-cr do not pass --keep-cr flag to git-mailsplit
>>>> independent of am.keepcr
>>>> +keep-cr pass --keep-cr flag to git mailsplit for mbox format
>>>> +no-keep-cr do not pass --keep-cr flag to git mailsplit
>>>> independent of am.keepcr
>>>> c,scissors strip everything before a scissors line
>>>> whitespace= pass it through git-apply
>>>> ignore-space-change pass it through git-apply
>>>
>>>> As you were saying yourself, we tell users to prefer the "git foo"
>>>> form, so we should also do so in the "git am" option help, IMHO.
>>>
>>> What does the above change to the options-help have anything to do
>>> with that theme? It does not seem to say anything about "git foo"
>>> vs "git-foo"?
>>
>> I initially missed it too, but `git-mailsplit` changed to `git
>> mailsplit` in the help.
>
> Ahh, OK.
>
>> Now that I look at it more, I see that
>> `git-mailinfo` was missed and there's a `git-apply` towards the
>> bottom. So I'm not sure it's helping the consistency argument.
>
> Hmph, true.
Having said that, I'd still prefer to see documentation changes in a
patch separate from a "do not call git-foo form" patch.
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-06-27 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 12:47 [PATCH] Do not call built-in aliases from scripts Sebastian Schuberth
2013-06-27 16:11 ` Junio C Hamano
2013-06-27 16:41 ` Sebastian Schuberth
2013-06-27 17:27 ` Junio C Hamano
2013-06-27 18:02 ` John Szakmeister
2013-06-27 18:05 ` Junio C Hamano
2013-06-27 18:10 ` Junio C Hamano [this message]
2013-06-28 20:18 ` Sebastian Schuberth
2013-06-27 18:11 ` John Keeping
2013-06-27 18:52 ` Johannes Schindelin
2013-06-28 20:23 ` Sebastian Schuberth
2013-06-28 20:32 ` Johannes Schindelin
2013-06-28 20:43 ` Junio C Hamano
2013-06-27 19:57 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vehbns9vq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@users.sourceforge.net \
--cc=sschuberth@gmail.com \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).