From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <stefanbeller@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: Fix a memory leak in determine_author_info
Date: Mon, 15 Jul 2013 07:42:56 -0700 [thread overview]
Message-ID: <7vehazevf3.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1373810463-7144-1-git-send-email-stefanbeller@googlemail.com> (Stefan Beller's message of "Sun, 14 Jul 2013 16:01:03 +0200")
Stefan Beller <stefanbeller@googlemail.com> writes:
> The date variable is assigned new memory via xmemdupz and 2 lines later
> it is assigned new memory again via xmalloc, but the first assignment
> is never freed nor used.
> ---
> builtin/commit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 790e5ab..00da83c 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -534,7 +534,6 @@ static void determine_author_info(struct strbuf *author_ident)
> (lb - strlen(" ") -
> (a + strlen("\nauthor "))));
> email = xmemdupz(lb + strlen("<"), rb - (lb + strlen("<")));
> - date = xmemdupz(rb + strlen("> "), eol - (rb + strlen("> ")));
> len = eol - (rb + strlen("> "));
> date = xmalloc(len + 2);
> *date = '@';
Makes sense. I'd assume this is signed-off?
next prev parent reply other threads:[~2013-07-15 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 14:01 [PATCH] commit: Fix a memory leak in determine_author_info Stefan Beller
2013-07-15 14:42 ` Junio C Hamano [this message]
2013-07-15 14:46 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vehazevf3.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).