From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add support for commit.signoff config option
Date: Tue, 28 Nov 2006 12:17:07 -0800 [thread overview]
Message-ID: <7vd5772unw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200611281202.43394.andyparkins@gmail.com
Andy Parkins <andyparkins@gmail.com> writes:
> Whether patches require signing off or not is probably a per-project
> setting rather than a per-commit setting. Therefore as a convenience to
> the user, the commit.signoff setting will automtically add --signoff to
> commits.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
I muttered something about commit templates which would make
this change a moot point, but independent of that...
> +# Config
> +case "$(git-repo-config --get commit.signoff)" in
> +1|on|yes|true)
> + signoff=t
> + ;;
> +esac
this is ugly; please use --bool and check only for 'true'.
next prev parent reply other threads:[~2006-11-28 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 12:02 [PATCH] Add support for commit.signoff config option Andy Parkins
2006-11-28 20:17 ` Junio C Hamano [this message]
2006-11-29 8:25 ` [PATCH] Add --bool and --int to the OPTIONS section Andy Parkins
2006-11-29 10:09 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd5772unw.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).