From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Carlos Rica <jasampler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-tag -s must fail if gpg is broken and cannot sign tags
Date: Wed, 05 Sep 2007 23:20:14 -0700 [thread overview]
Message-ID: <7vd4wwe2n5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070906042653.GQ18160@spearce.org> (Shawn O. Pearce's message of "Thu, 6 Sep 2007 00:26:53 -0400")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> "Shawn O. Pearce" <spearce@spearce.org> wrote:
>> If the user has misconfigured `user.signingkey` in their .git/config
>> or just doesn't have any secret keys on their keyring and they ask
>> for a signed tag with `git tag -s` we better make sure the resulting
>> tag was actually signed by gpg.
> ...
>> I think this and my prior contrib/workdir patch should both go into
>> maint. This one in particular; it hurt us today when an automated
>> tool that runs `git tag -s` didn't notice the GnuPG problems.
>
> I'm sorry, despite the subject of this email this is actually a
> *one* patch series. The 2/2 is because I applied and tested this
> on top of the contrib/workdir patch I was talking about above and
> my email sending script thought it was a two patch series.
This seems to fail the test depending on the order processes
happen to be scheduled. I haven't looked at it closely yet.
next prev parent reply other threads:[~2007-09-06 6:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 4:21 [PATCH 2/2] git-tag -s must fail if gpg is broken and cannot sign tags Shawn O. Pearce
2007-09-06 4:26 ` Shawn O. Pearce
2007-09-06 6:20 ` Junio C Hamano [this message]
2007-09-07 4:58 ` Shawn O. Pearce
2007-09-08 5:41 ` Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd4wwe2n5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).