From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 07/10] git-fmt-merge-msg: make it useable from other builtins Date: Thu, 05 Jun 2008 16:12:00 -0700 Message-ID: <7vd4mvzdbz.fsf@gitster.siamese.dyndns.org> References: <0a2c2130f9fd87e98192ab0fe0d23e16c902997c.1212698317.git.vmiklos@frugalware.org> <9867fa302ce1c28f4bd8534a70bda19786c75971.1212698317.git.vmiklos@frugalware.org> <5aca216074b88d68f97b8223ebf6272dfe6bddeb.1212698317.git.vmiklos@frugalware.org> <3168647573b1325f47ab16f9ee3cae5abaaee473.1212698317.git.vmiklos@frugalware.org> <01dd116d05eedba51578935e39f679a8747380d6.1212698317.git.vmiklos@frugalware.org> <514d4184569ab033cad97be9afbd88c767bfb484.1212698317.git.vmiklos@frugalware.org> <2e4b20178405cf993ce9e0f1ffe4ac402a96fd03.1212698317.git.vmiklos@frugalware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Miklos Vajna X-From: git-owner@vger.kernel.org Fri Jun 06 01:13:29 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1K4Oe4-0000r9-6H for gcvg-git-2@gmane.org; Fri, 06 Jun 2008 01:13:24 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764044AbYFEXMM (ORCPT ); Thu, 5 Jun 2008 19:12:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754048AbYFEXML (ORCPT ); Thu, 5 Jun 2008 19:12:11 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:39540 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764008AbYFEXMJ (ORCPT ); Thu, 5 Jun 2008 19:12:09 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id F08A33E26; Thu, 5 Jun 2008 19:12:05 -0400 (EDT) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 494443E25; Thu, 5 Jun 2008 19:12:03 -0400 (EDT) In-Reply-To: <2e4b20178405cf993ce9e0f1ffe4ac402a96fd03.1212698317.git.vmiklos@frugalware.org> (Miklos Vajna's message of "Thu, 5 Jun 2008 22:44:33 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: D0869A84-3354-11DD-A0DC-F9737025C2AA-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Miklos Vajna writes: > Move all functionality (except config and option parsing) from > cmd_fmt_merge_msg() to fmt_merge_msg(), so that other builtins can use > it without a child process. > > All functions have been changed to use strbufs, and now only > cmd_fmt_merge_msg() reads directly from a file / writes anything to > stdout. > > Signed-off-by: Miklos Vajna The word in the title should be "usable" (s/sea/sa/). Other than that, looks like a quite straightforward conversion.