From: Junio C Hamano <gitster@pobox.com>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Allow git log to use mailmap file
Date: Sat, 15 Dec 2012 12:18:38 -0800 [thread overview]
Message-ID: <7vd2ybrrvl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1355594754-27589-1-git-send-email-apelisse@gmail.com> (Antoine Pelisse's message of "Sat, 15 Dec 2012 19:05:47 +0100")
Antoine Pelisse <apelisse@gmail.com> writes:
> Implement the feature suggested by Rich Mindwinter and Junio C Hamano
> (and following his advices)
>
>
>
> Allows git show/log commands to map author and committer
> names and emails using the mailmap file.
>
> Updates related to this second series:
> - All tests are successful after each patch
> - Use split_ident_line in shortlog.c
> - Documentation has been added to git-log.txt
> - Test has been added to check that we use the file
> - Lots of improvements in the way strbufs are used
> - New interface to map_user()
> - Bunch of other fixes
The updated map_user() and its users look much nicer now. Applying
your patches with "git am --whitespace=error" spots a few style
violations, though.
> git glog --committer/--author is still not looking for mailmap user
> names.
I think we should stop using the header grep mechanism for these and
instead keep two separate grep expressions in struct rev_info and
use them in revision.c::commit_match(). The unification of header
filter and message grep filter done in 2d10c55 (git log: Unify
header_filter and message_filter into one., 2006-09-20) may not have
been a good idea.
Thanks.
prev parent reply other threads:[~2012-12-15 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 18:05 [PATCH v2 0/7] Allow git log to use mailmap file Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 1/7] Use split_ident_line to parse author and committer Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 2/7] mailmap: Remove buffer length limit in map_user Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 3/7] mailmap: Simplify map_user() interface Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 4/7] mailmap: Add mailmap structure to rev_info and pp Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 5/7] pretty: Use mailmap to display username and email Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 6/7] log: Add --use-mailmap option Antoine Pelisse
2012-12-15 18:05 ` [PATCH v2 7/7] test: Add test for " Antoine Pelisse
2012-12-15 20:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd2ybrrvl.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).