git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] git-config: update doc for --get with multiple values
Date: Wed, 03 Jul 2013 11:47:50 -0700
Message-ID: <7vd2qzfpk9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <41dc25ceac50731a7c5da753c04b7c13c41c1b51.1372876047.git.john@keeping.me.uk> (John Keeping's message of "Wed, 3 Jul 2013 19:27:39 +0100")

John Keeping <john@keeping.me.uk> writes:

> Since commit 00b347d (git-config: do not complain about duplicate
> entries, 2012-10-23), "git config --get" does not exit with an error if
> there are multiple values for the specified key but instead returns the
> last value.  Update the documentation to reflect this.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
>  Documentation/git-config.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 19a7be0..fbad05e 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -82,7 +82,7 @@ OPTIONS
>  --get::
>  	Get the value for a given key (optionally filtered by a regex
>  	matching the value). Returns error code 1 if the key was not
> -	found and error code 2 if multiple key values were found.
> +	found and the last value if multiple key values were found.
>  
>  --get-all::
>  	Like get, but does not fail if the number of values for the key

Thanks.

I wondered if we should explain the significance of "last" a bit
more (like "this results in the value from the most specific
configuration file to be used, the ones in $GIT_DIR/config
overriding what is in $HOME/.gitconfig"), but I do not have a strong
opinion either way.  Let's queue this for 'maint' for now.

  parent reply	other threads:[~2013-07-03 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-03 18:27 John Keeping
2013-07-03 18:32 ` Jeff King
2013-07-03 18:47 ` Junio C Hamano [this message]
2013-07-07  9:50   ` John Keeping
2013-07-07 17:31     ` Junio C Hamano
2013-07-07 19:49       ` [PATCH] git-config(1): clarify precedence of " John Keeping
2013-07-07 19:55         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd2qzfpk9.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=john@keeping.me.uk \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git