From: Junio C Hamano <junkio@cox.net>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>, git@vger.kernel.org
Subject: Re: Fw: [PATCH 31/49] PCI: PCI/Cardbus cards hidden, needs pci=assign-busses to fix
Date: Thu, 23 Mar 2006 17:26:29 -0800 [thread overview]
Message-ID: <7vbqvw3a62.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060324004654.GA19763@kroah.com> (Greg KH's message of "Thu, 23 Mar 2006 16:46:54 -0800")
Greg KH <greg@kroah.com> writes:
> I'm using:
> git format-patch -n origin..HEAD
> to generate the raw patch files, and then:
> git-send-email --in-reply-to "<some_message_id>" --to some_mailing_list@somewhere.com
>
> fixing the obvious message id and mailing list address to be the correct
> one depending on the subsystem the patches are from.
I think format-patch does the right thing (I wrote it), but I am
not sure what send-email does wrt the From: header. Who wrote
the send-email anyway? I see your name on it ;-)
The cleanest way send-email should handle a patch authored by
somebody other than you, I think, is to still use From: to name
the author (format-patch output records the author on From:
line), and use Sender: of the outgoing e-mail to record that the
message is from you. I suspect it probably doesn't.
The second best would be to add the duplicated From: to name the
author (who is _not_ you) to the top of the body of the message.
I do not particularly like that format myself, though. Sender:
header was invented to send an e-mail authored by somebody other
than the sender of the message at the mail transport level, long
before Documentation/SubmittingPatches were written and git was
invented, and somehow I think that is a more kosher way to
handle that than the "extra From: at the beginning of the
message" clutch recommended in SubmittingPatches document.
On the acceptance side, "git am" (or "git applymbox") should be
able to handle either format.
next prev parent reply other threads:[~2006-03-24 1:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060323161521.28a874e6.akpm@osdl.org>
[not found] ` <20060324002930.GA21184@kroah.com>
[not found] ` <20060323163844.5fda7589.akpm@osdl.org>
2006-03-24 0:46 ` Fw: [PATCH 31/49] PCI: PCI/Cardbus cards hidden, needs pci=assign-busses to fix Greg KH
2006-03-24 0:55 ` Greg KH
2006-03-24 1:26 ` Junio C Hamano [this message]
2006-03-24 1:51 ` Andrew Morton
2006-03-24 2:27 ` Junio C Hamano
2006-03-24 6:17 ` Greg KH
2006-03-24 7:44 ` Junio C Hamano
2006-03-24 17:23 ` Ryan Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbqvw3a62.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=akpm@osdl.org \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).