From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Subject: [PATCH] fsck.c: fix bogus "empty tree" check
Date: Tue, 04 Mar 2008 03:21:16 -0800 [thread overview]
Message-ID: <7vbq5u91lf.fsf@gitster.siamese.dyndns.org> (raw)
ba002f3 (builtin-fsck: move common object checking code to fsck.c) did
more than what it claimed to. Most notably, it wrongly made an empty tree
object an error by pretending to only move code from fsck_tree() in
builtin-fsck.c to fsck_tree() in fsck.c, but in fact adding a bogus check
to barf on an empty tree.
An empty tree object is _unusual_. Recent porcelains try reasonably hard
not to let the user create a commit that contains such a tree. Perhaps
warning about them in git-fsck may have some merit.
However, being unusual and being errorneous are two quite different
things. This is especially true now we seem to use the same
fsck_$object() code in places other than git-fsck itself. For example,
receive-pack should not reject unusual objects, even if it would be a good
idea to tighten it to reject incorrect ones.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* I've wasted a few hours tonight hunting for random breakages in "git
push", the symptom of which is "fatal: unresolved deltas left after
unpacking." I was hoping this patch would fix it, but it seems that
the problem is elsewhere.
I'll revert the following two commits for now:
d5ef408 (unpack-objects: prevent writing of inconsistent objects)
28f72a0 (receive-pack: use strict mode for unpacking objects)
as I have verified that running with receive.fsckobjects set to false
fixes the issues for me, and the repository at the receiving end (both
before and after the push) pass git-fsck without problems. Needless to
say, I am not a happy camper right now.
fsck.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fsck.c b/fsck.c
index 6883d1b..797e317 100644
--- a/fsck.c
+++ b/fsck.c
@@ -155,8 +155,6 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
o_mode = 0;
o_name = NULL;
o_sha1 = NULL;
- if (!desc.size)
- return error_func(&item->object, FSCK_ERROR, "empty tree");
while (desc.size) {
unsigned mode;
--
1.5.4.3.529.gb25fb
next reply other threads:[~2008-03-04 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 11:21 Junio C Hamano [this message]
2008-03-04 12:26 ` [PATCH] fsck.c: fix bogus "empty tree" check Sergey Vlasov
2008-03-04 19:57 ` Junio C Hamano
2008-03-05 8:47 ` [PATCH] t5300: add test for "unpack-objects --strict" Junio C Hamano
2008-03-05 9:17 ` [PATCH v2] " Junio C Hamano
2008-03-04 21:48 ` [PATCH] fsck.c: fix bogus "empty tree" check Martin Koegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq5u91lf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).