From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add support to git-branch to show local and remote branches
Date: Fri, 03 Nov 2006 11:19:51 -0800 [thread overview]
Message-ID: <7vac388hig.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200611031240.34177.andyparkins@gmail.com> (Andy Parkins's message of "Fri, 3 Nov 2006 13:40:30 +0100")
Andy Parkins <andyparkins@gmail.com> writes:
> On Friday 2006 November 03 12:08, Junio C Hamano wrote:
>
>> > +static int tidy_ref_list( struct ref_list *ref_list )
>>
>> Style. No spaces before or after parameter list.
>
> Bah! It's so hard getting my fingers to remember what style goes in which
> project :-)
>
>> I see you already parse "refs/tags" prefix. "git branch" would
>> not print tags, but that part might be useful when we want to
>> redo git-tag in C.
>
> I'm going to have a look at that soon;...
Just to make sure you do not misunderstand. I do not see much
need for rewriting git-tag in C right now, and often it is more
convenient to leave higher layer commands in shell scripts to
allow people to try out new things and flush out UI issues. I
was merely pointing out that part of the code would be usable if
we were to do it.
next prev parent reply other threads:[~2006-11-03 19:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bec6ab7849e3fcacac23cca44a0ba93282af5fca.1162465753.git.andyparkins@gmail.com>
2006-11-02 11:11 ` [PATCH 2/4] Rename remote_only to display_mode Andy Parkins
2006-11-03 2:40 ` Junio C Hamano
2006-11-03 8:40 ` Andy Parkins
2006-11-03 10:51 ` Andreas Ericsson
2006-11-03 11:51 ` Junio C Hamano
2006-11-03 12:37 ` Andy Parkins
2006-11-03 12:00 ` Andy Parkins
2006-11-03 13:23 ` Andreas Ericsson
2006-11-03 10:52 ` [PATCH] Add support to git-branch to show local and remote branches Andy Parkins
2006-11-03 12:06 ` [PATCH] Colourise git-branch output Andy Parkins
2006-11-03 19:25 ` Junio C Hamano
2006-11-03 23:05 ` Alex Riesen
2006-11-03 12:08 ` [PATCH] Add support to git-branch to show local and remote branches Junio C Hamano
2006-11-03 12:40 ` Andy Parkins
2006-11-03 19:19 ` Junio C Hamano [this message]
2006-11-02 11:11 ` [PATCH 3/4] Default to displaying /all/ non-tag refs, not just locals Andy Parkins
2006-11-03 2:40 ` Junio C Hamano
2006-11-03 8:47 ` Andy Parkins
2006-11-03 10:55 ` Andreas Ericsson
2006-11-02 11:11 ` [PATCH 4/4] Show the branch type after the branch name for remotes Andy Parkins
2006-11-03 2:40 ` Junio C Hamano
2006-11-03 8:33 ` Andy Parkins
2006-11-03 20:08 ` Junio C Hamano
2006-11-21 19:31 [PATCH] Add support to git-branch to show local and remote branches Andy Parkins
2006-11-21 21:14 ` Junio C Hamano
2006-11-22 8:53 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vac388hig.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).