From: Junio C Hamano <gitster@pobox.com>
To: Michael Witten <mfwitten@MIT.EDU>
Cc: git@vger.kernel.org
Subject: Re: [PATCH review] Build: make PERL_PATH = /usr/bin/env perl
Date: Sat, 31 May 2008 12:55:12 -0700 [thread overview]
Message-ID: <7vabi6fdun.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1212258886-87484-1-git-send-email-mfwitten@mit.edu> (Michael Witten's message of "Sat, 31 May 2008 14:34:46 -0400")
Michael Witten <mfwitten@MIT.EDU> writes:
> This should make PERL_PATH more robust, as some
> systems may have multiple version of perl installed.
>
> Signed-off-by: Michael Witten <mfwitten@mit.edu>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 865e2bf..5828745 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -323,7 +323,7 @@ ifndef SHELL_PATH
> SHELL_PATH = /bin/sh
> endif
> ifndef PERL_PATH
> - PERL_PATH = /usr/bin/perl
> + PERL_PATH = /usr/bin/env perl
> endif
>
> export PERL_PATH
If you insist, you can do so from your "make" command line, but I'd prefer
the default configuration as vanilla as possible.
I notice that both git-svn.perl and git-relink.perl begin with
"#!/usr/bin/env perl", and I think that is a mistake. The #! line is
rewritten by Makefile, and there is no reason to write a "/usr/bin/env"
ugliness there in the source. Not that it hurts, as it is blown away when
Makefile rewrites it to "#!$(PERL_PATH)", but it still looks ugly.
next prev parent reply other threads:[~2008-05-31 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 18:34 [PATCH review] Build: make PERL_PATH = /usr/bin/env perl Michael Witten
2008-05-31 19:55 ` Junio C Hamano [this message]
2008-06-01 4:48 ` Michael Witten
2008-06-01 8:22 ` Matthieu Moy
2008-06-01 9:01 ` Junio C Hamano
2008-06-01 18:11 ` Steven Walter
2008-06-02 2:17 ` David Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vabi6fdun.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mfwitten@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).