git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation/git-ls-tree.txt: Add a caveat about prefixing pathspec
Date: Mon, 28 Jul 2008 02:23:46 -0700	[thread overview]
Message-ID: <7vabg2s6ot.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vvdyqx0i0.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 27 Jul 2008 18:26:15 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Petr Baudis <pasky@suse.cz> writes:
>
>>> We may throw a dice or go with your version, I don't care *that* much
>>> about this change, I just wouldn't make it personally.
>>
>> What is the status of this patch? :-) Dropped altogether?
>
> Left behind on the far side of oblivion; I do not offhand recall what this
> was about, sorry.

Ok, I now recall this bit:

        You are right, now that I understand the issue better, there's no good
        fix for this except perhaps introducing --no-prefix, which is not my
        itch to scratch. Here's my original wording improvement:

                Note that if you are within a subdirectory of your working copy,
                'git ls-tree' will automatically prepend the subdirectory prefix
                to the specified paths, and assume the prefix specified in case
                no paths were given - no matter what the tree object is! Thus,
                within a subdirectory, 'git ls-tree' behaves as expected only
                when run on a root tree object.

Eventually somebody may write a Porcelain that benefits from --no-prefix,
but it is safe to defer the implementation until the need becomes real.

I'll add some explanatory message to the documentation.

  reply	other threads:[~2008-07-28  9:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-20 22:25 [PATCH] Add a notice to the doc of git-ls-tree Steve Frécinaux
2008-07-20 23:08 ` Petr Baudis
2008-07-20 23:22   ` Steve Frécinaux
2008-07-20 23:24   ` Junio C Hamano
2008-07-20 23:39     ` Petr Baudis
2008-07-21  7:56       ` [PATCH] Documentation/git-ls-tree.txt: Add a caveat about prefixing pathspec Petr Baudis
2008-07-21  8:00         ` Junio C Hamano
2008-07-21 21:04           ` Petr Baudis
2008-07-22  0:32             ` Junio C Hamano
2008-07-22 22:47               ` Petr Baudis
2008-07-28  0:46                 ` Petr Baudis
2008-07-28  1:26                   ` Junio C Hamano
2008-07-28  9:23                     ` Junio C Hamano [this message]
2008-07-21  8:45         ` Steve Frécinaux
2008-07-20 23:53     ` [PATCH] Add a notice to the doc of git-ls-tree Junio C Hamano
2008-07-21  0:08       ` Petr Baudis
2008-07-21  0:14         ` Junio C Hamano
2008-07-21  0:22           ` Petr Baudis
2008-07-21  4:28             ` Junio C Hamano
2008-07-21  7:47               ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabg2s6ot.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).