From: Junio C Hamano <gitster@pobox.com>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v2] log: grep author/committer using mailmap
Date: Fri, 28 Dec 2012 10:43:30 -0800 [thread overview]
Message-ID: <7va9syj9v1.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALWbr2y63L0-ykdUNGqUOb0LhG=vpXGRcb1KkvssEZmKFJEGeQ@mail.gmail.com> (Antoine Pelisse's message of "Fri, 28 Dec 2012 19:00:50 +0100")
Antoine Pelisse <apelisse@gmail.com> writes:
> Actually, gprof seems to be unhappy about the number of call to
> strbuf_grow() in map_user() (25% of the time spent in map_user() is
> spent in strbuf_grow()).
>
> That probably comes from the repeated call to strbuf_addch() when
> lowering the email address.
This is about your rewritten implementation that hasn't escaped to
the general public but sitting in 'next', right?
Two things that immediately come to mind are:
- initialization of lowermail can use strbuf_init() instead;
- downcasing can be done in place, i.e. "lowermail.buf[i] = ...".
next prev parent reply other threads:[~2012-12-28 18:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 16:58 [PATCH 0/2] Mailmap in log improvements Antoine Pelisse
2012-12-22 16:58 ` [PATCH 1/2] log: grep author/committer using mailmap Antoine Pelisse
2012-12-26 19:27 ` Junio C Hamano
2012-12-26 21:12 ` Antoine Pelisse
2012-12-26 21:37 ` Junio C Hamano
2012-12-27 15:31 ` [PATCH v2] " Antoine Pelisse
2012-12-27 18:45 ` Junio C Hamano
2012-12-27 18:48 ` Junio C Hamano
2012-12-28 18:00 ` Antoine Pelisse
2012-12-28 18:43 ` Junio C Hamano [this message]
2012-12-28 20:37 ` Antoine Pelisse
2012-12-22 16:58 ` [PATCH 2/2] log: add log.mailmap configuration option Antoine Pelisse
2012-12-23 4:26 ` Junio C Hamano
2012-12-26 16:14 ` Junio C Hamano
2012-12-26 16:42 ` Antoine Pelisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7va9syj9v1.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).