From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Michael Campbell <michael.campbell@gmail.com>,
git@vger.kernel.org
Subject: Re: Should "git help" respect the 'pager' setting?
Date: Sun, 02 Jun 2013 15:24:09 -0700 [thread overview]
Message-ID: <7va9n8m9rq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130530171431.GF17475@serenity.lan> (John Keeping's message of "Thu, 30 May 2013 18:14:31 +0100")
John Keeping <john@keeping.me.uk> writes:
> On Thu, May 30, 2013 at 10:38:59PM +0530, Ramkumar Ramachandra wrote:
>> Matthieu Moy wrote:
>> > I find it a bit weird that Git sets the configuration for external
>> > commands, but it may make sense. No strong opinion here.
>>
>> I don't mean a setenv() kind of thing: how would we unset it after
>> that? Perhaps something like execvpe(), passing in the environment as
>> an argument?
Running "man" is the last thing we do before exitting "git help" and
exec_man_man() does seem to do execlp(), so I do not see it as an
issue.
> Overriding PAGER might make sense, but I'd be quite annoyed if Git
> decided to override MANPAGER without providing some way to override it.
Hmm, see below.
> If a user sets MANPAGER then it's because they want a specific pager
> when reading man pages - invoking man through "git help" shouldn't cause
> it to behave differently in this case.
True, and for that matter, if the user sets PAGER to use with
non-Git (including manual pages) and also sets GIT_PAGER to use
specifically with Git, the user would be annoyed if we passed
formatted manual pages to GIT_PAGER by exporting PAGER (or driving
"man" with its "-P" option).
prev parent reply other threads:[~2013-06-02 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 16:33 Should "git help" respect the 'pager' setting? Michael Campbell
2013-05-30 16:42 ` Matthieu Moy
2013-05-30 16:56 ` Ramkumar Ramachandra
2013-05-30 17:05 ` Matthieu Moy
2013-05-30 17:08 ` Ramkumar Ramachandra
2013-05-30 17:14 ` John Keeping
2013-06-02 22:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7va9n8m9rq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=michael.campbell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).