git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] rebase -i: write better reflog messages for start
Date: Thu, 13 Jun 2013 09:55:40 -0700	[thread overview]
Message-ID: <7va9muvtkj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALkWK0=o0OxTjim=+qoBhpHkWQoVWLWjkJPqknPbr29T5ax46Q@mail.gmail.com> (Ramkumar Ramachandra's message of "Thu, 13 Jun 2013 16:02:54 +0530")

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Ramkumar Ramachandra wrote:
>> t/status-help.  Looks seriously unrelated, and I'm breaking my head
>> over it.  Any clues?
>
> Damn it!  A recent commit is responsible for this avalanche in test
> breakages: b397ea (status: show more info than "currently not on any
> branch", 2013-03-13).  It re-implements a backward version of
> grab_nth_branch_switch(): grab_1st_switch() essentially _relies_ on
> the random unintended pollution that rebase writes to the reflog to
> print a more useful (?) status :/

After "git checkout v1.3.0", it is reasonable to expect that you can
tell what you checked out and what state you are in.  If you then
made a few commits or resetted to some other commit, it is debatable
if "detached from v1.3.0" is useful or the subtle difference between
"detached at" vs "detached from" is confusing.

But what does it have to do with rebase polluting the reflog?

  reply	other threads:[~2013-06-13 16:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 16:22 [PATCH 0/3] Fix git checkout - (early preview) Ramkumar Ramachandra
2013-06-10 16:22 ` [PATCH 1/3] t/checkout-last: checkout - doesn't work after rebase -i Ramkumar Ramachandra
2013-06-10 18:29   ` Junio C Hamano
2013-06-13  7:13     ` Ramkumar Ramachandra
2013-06-10 16:22 ` [PATCH 2/3] checkout: respect GIT_REFLOG_ACTION Ramkumar Ramachandra
2013-06-10 18:31   ` Junio C Hamano
2013-06-10 16:22 ` [PATCH 3/3] rebase -i: write better reflog messages for start Ramkumar Ramachandra
2013-06-10 18:32   ` Junio C Hamano
2013-06-10 18:36     ` Ramkumar Ramachandra
2013-06-13 10:32       ` Ramkumar Ramachandra
2013-06-13 16:55         ` Junio C Hamano [this message]
2013-06-13 17:05           ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7va9muvtkj.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).