git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrew Pimlott <andrew@pimlott.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] lib-rebase: use write_script
Date: Thu, 27 Jun 2013 11:37:31 -0700	[thread overview]
Message-ID: <7va9mbs8lw.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1372357825-21824-1-git-send-email-andrew@pimlott.net> (Andrew Pimlott's message of "Thu, 27 Jun 2013 11:30:25 -0700")

Andrew Pimlott <andrew@pimlott.net> writes:

> Signed-off-by: Andrew Pimlott <andrew@pimlott.net>
> ---
>  t/lib-rebase.sh |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh
> index 0b41155..7b42199 100644
> --- a/t/lib-rebase.sh
> +++ b/t/lib-rebase.sh
> @@ -24,8 +24,7 @@
>  #   ">" -- Add a blank line.
>  
>  set_fake_editor () {
> -	echo "#!$SHELL_PATH" >fake-editor.sh
> -	cat >> fake-editor.sh <<\EOF
> +	write_script fake-editor.sh <<\EOF
>  case "$1" in
>  */COMMIT_EDITMSG)
>  	test -z "$EXPECT_HEADER_COUNT" ||
> @@ -65,7 +64,6 @@ cat "$1"
>  EOF
>  
>  	test_set_editor "$(pwd)/fake-editor.sh"
> -	chmod a+x fake-editor.sh
>  }
>  
>  # After set_cat_todo_editor, rebase -i will write the todo list (ignoring

Thanks, but it should probably be

	write_script fake-editor.sh <<-\EOF
        case "$1" in
        ...
        EOF

        test_set_editor ...

if the aim is to modernize this part.

  reply	other threads:[~2013-06-27 18:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 18:30 [PATCH] lib-rebase: use write_script Andrew Pimlott
2013-06-27 18:37 ` Junio C Hamano [this message]
2013-06-27 19:02   ` Andrew Pimlott
2013-06-27 20:50     ` Junio C Hamano
2013-07-01 16:23       ` Andrew Pimlott
2013-07-01 16:56         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7va9mbs8lw.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=andrew@pimlott.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).