git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Convert "struct cache_entry *" to "const ..." wherever possible
Date: Tue, 09 Jul 2013 09:15:48 -0700	[thread overview]
Message-ID: <7va9lvwvyj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1373383740-24440-1-git-send-email-pclouds@gmail.com> ("Nguyễn	Thái Ngọc Duy"'s message of "Tue, 9 Jul 2013 22:29:00 +0700")

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> I attempted to make index_state->cache[] a "const struct cache_entry **"
> to find out how existing entries in index are modified and where. The
> question I have is what do we do if we really need to keep track of on-disk
> changes in the index. The result is
>
>  - diff-lib.c: setting CE_UPTODATE
>
>  - name-hash.c: setting CE_HASHED
>
>  - preload-index.c, read-cache.c, unpack-trees.c and
>    builtin/update-index: obvious
>
>  - entry.c: write_entry() may refresh the checked out entry via
>    fill_stat_cache_info(). This causes "non-const struct cache_entry
>    *" in builtin/apply.c, builtin/checkout-index.c and
>    builtin/checkout.c
>
>  - builtin/ls-files.c: --with-tree changes stagemask and may set
>    CE_UPDATE
>
> Of these, write_entry() and its call sites are probably most
> interesting because it modifies on-disk info. But this is stat info
> and can be retrieved via refresh, at least for porcelain
> commands. Other just uses ce_flags for local purposes.
>
> So, keeping track of "dirty" entries is just a matter of setting a
> flag in index modification functions exposed by read-cache.c. Except
> unpack-trees, the rest of the code base does not do anything funny
> behind read-cache's back.
>
> The actual patch is less valueable than the summary above. But if
> anyone wants to re-identify the above sites. Applying this patch, then
> this:
>
>     diff --git a/cache.h b/cache.h
>     index 430d021..1692891 100644
>     --- a/cache.h
>     +++ b/cache.h
>     @@ -267,7 +267,7 @@ static inline unsigned int canon_mode(unsigned int mode)
>      #define cache_entry_size(len) (offsetof(struct cache_entry,name) + (len) + 1)
>     
>      struct index_state {
>     -	struct cache_entry **cache;
>     +	const struct cache_entry **cache;
>      	unsigned int version;
>      	unsigned int cache_nr, cache_alloc, cache_changed;
>      	struct string_list *resolve_undo;
>
> will help quickly identify them without bogus warnings.

Nicely done and a very interesting result.  I quickly eyeballed the
output of

$ git grep -e 'struct cache_entry' --and --not -e 'const struct cache_entry'

and the result matches what I would expect to see.

      reply	other threads:[~2013-07-09 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 15:29 [PATCH] Convert "struct cache_entry *" to "const ..." wherever possible Nguyễn Thái Ngọc Duy
2013-07-09 16:15 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7va9lvwvyj.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).