git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Rename git-config-set to git-repo-config
Date: Thu, 24 Nov 2005 03:33:30 -0800	[thread overview]
Message-ID: <7v8xveth4l.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: Pine.LNX.4.63.0511241127020.12985@wbgn013.biozentrum.uni-wuerzburg.de

Thanks for the patch.  I unfortunately was doing the same,
because I wanted to get the repo-format-validation stuff into a
presentable shape, and I thought this would interfere with it
and wanted to do it first (fortunately it didn't).  They are
both in the proposed updates branch.  At a quick glance, I think
your patch is identical to what I did (there aren't that many
different ways to rename a command after all).

> 	Sorry, git-mv did not work on my system. I can now confirm that
> 	there is *at least* one perl 5.6 version out there which does not
> 	like lists in open statements at all. Grmpf.

Yeah, perl5.8delta says that is 5.8 feature.  As discussed on
the list with Merlyn, we have a fair amount of backporting, I
suspect.  At least we should work on 5.6, if not 5.5.

I do not use git-mv myself.  It does not work in subdirectories,
and typing Documentation/ twice to move just one file is a
chore, so I tend to just 'R' (rename) the file, move to the
renamed file, and '!' (run shell command on the specified path)
with 'git-add', all within a single Emacs dired buffer.

> 	Further grpmf: Is it intended behaviour that git-diff *detects* 
> 	renames, while git-format-patch *doesn't*?

I do not want to force all the kernel subsystem maintainers to
use git (namely, git-apply) to process e-mails, so format-patch
should not default to git specific renaming patches.

An option to git-format-patch _might_ make sense someday.  Maybe
after the world domination ;-).

Oh, wait.  It already can produce renaming patches, just does
not do it by default.

		Junio "again I forgot what I implemented before;
		sheesh I even used it myself to feed some patches
                to Linus" Hamano
 

  reply	other threads:[~2005-11-24 11:33 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-20 17:00 Get rid of .git/branches/ and .git/remotes/? Johannes Schindelin
2005-11-20 18:09 ` Linus Torvalds
2005-11-20 18:29   ` Sven Verdoolaege
2005-11-20 19:07     ` Linus Torvalds
2005-11-20 19:16       ` Andreas Ericsson
2005-11-20 19:50   ` Johannes Schindelin
2005-11-26 23:50     ` Petr Baudis
2005-11-27  0:38       ` Junio C Hamano
2005-11-20 23:26   ` Josef Weidendorfer
2005-11-20 23:58     ` Johannes Schindelin
2005-11-22 17:31     ` Josef Weidendorfer
2005-11-22 17:56       ` Johannes Schindelin
2005-11-22 19:30         ` Andreas Ericsson
2005-11-23 15:08           ` Johannes Schindelin
2005-11-23 23:21             ` Junio C Hamano
2005-11-23 23:29               ` Andreas Ericsson
2005-11-23 23:42                 ` Johannes Schindelin
2005-11-24  8:05                   ` Andreas Ericsson
2005-11-24  8:33                     ` Junio C Hamano
2005-11-24 10:36                       ` [PATCH] Rename git-config-set to git-repo-config Johannes Schindelin
2005-11-24 11:33                         ` Junio C Hamano [this message]
2005-11-24 13:28                           ` Johannes Schindelin
2005-11-24 21:24                             ` Junio C Hamano
2005-11-24 21:54                               ` Johannes Schindelin
2005-11-26  2:22                                 ` Junio C Hamano
2005-11-26  4:05                                   ` Linus Torvalds
2005-11-26  4:07                                     ` Linus Torvalds
2005-11-26  9:51                                     ` [PATCH 0/8] Make C-level operable from subdirectories Junio C Hamano
2005-11-26 10:59                                       ` Junio C Hamano
2005-11-26 18:44                                       ` Ryan Anderson
2005-11-27  9:21                                     ` [PATCH 6/8] ls-tree: work from subdirectory Junio C Hamano
2005-11-27 11:08                                       ` Petr Baudis
2005-11-27 18:01                                       ` Linus Torvalds
2005-11-27 18:22                                         ` Petr Baudis
2005-11-27 19:00                                           ` Linus Torvalds
2005-11-28  1:07                                             ` Junio C Hamano
2005-11-28  1:46                                               ` Linus Torvalds
2005-11-28  6:11                                                 ` Junio C Hamano
2005-11-28  6:48                                                   ` Linus Torvalds
2005-11-28  8:32                                                     ` Junio C Hamano
2005-11-28 10:51                                                       ` Junio C Hamano
2005-11-28 10:51                                                     ` [PATCH] ls-tree: Resurrect funny name quoting lost during rewrite Junio C Hamano
2005-11-26  5:52                               ` [PATCH] Rename git-config-set to git-repo-config Junio C Hamano
2005-11-26  9:56                               ` [PATCH 1/8] git-apply: work from subdirectory Junio C Hamano
2005-11-26 17:36                                 ` Linus Torvalds
2005-11-26 18:54                                   ` Junio C Hamano
2005-11-27  4:06                                   ` Junio C Hamano
2005-11-27 14:39                                     ` Lars Magne Ingebrigtsen
     [not found]                                       ` <7vy839dfzk.fsf@assigned-by-dhcp.cox.net>
2005-11-27 21:13                                         ` Lars Magne Ingebrigtsen
2005-11-27 22:12                                           ` Junio C Hamano
2005-11-26  9:56                               ` [PATCH 2/8] peek-remote: honor proxy config even " Junio C Hamano
2005-11-26  9:56                               ` [PATCH 3/8] fsck-objects: work " Junio C Hamano
2005-11-26  9:56                               ` [PATCH 4/8] checkout-index: " Junio C Hamano
2005-11-26  9:57                               ` [PATCH 5/8] hash-object: work within subdirectory Junio C Hamano
2005-11-26  9:57                               ` [PATCH 6/8] ls-tree: work from subdirectory Junio C Hamano
2005-11-26 17:38                                 ` Linus Torvalds
2005-11-26  9:57                               ` [PATCH 7/8] Make networking commands to work from a subdirectory Junio C Hamano
2005-11-26  9:57                               ` [PATCH 8/8] Make the rest of commands " Junio C Hamano
2005-11-22 23:05         ` Get rid of .git/branches/ and .git/remotes/? Josef Weidendorfer
2005-11-23 14:53           ` Johannes Schindelin
2005-11-23 15:39             ` Josef Weidendorfer
2005-11-23 17:22               ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8xveth4l.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).