From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] git add: do not add files from a submodule
Date: Wed, 23 Jul 2008 11:31:16 -0700 [thread overview]
Message-ID: <7v8wvse9l7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080723081333.GA15243@artemis.madism.org> (Pierre Habouzit's message of "Wed, 23 Jul 2008 10:13:33 +0200")
Pierre Habouzit <madcoder@debian.org> writes:
> On Wed, Jul 23, 2008 at 06:40:20AM +0000, Junio C Hamano wrote:
> ...
>> If we started the process of diagnosing and fixing these issues earlier,
>> and had plausible code to address the issue already in 'next' before the
>> current -rc cycle started, the topic would have been an obvious candidate
>> for the coming release and I'd further say it would be even worth delaying
>> the release for a few weeks if it takes more time. But I have to say it
>> is too late for 1.6.0 now if we are just noticing and starting the
>> discussion.
>
> Well given that we now use submodules at work, and that git is
> nowadays somewhere in the top 5 of my most consciously (as opposed to
> the compiler that I rarely call by hand) used software suites (among my
> editor, my MUA, my shell and my tiling WM), I'm very much interested in
> tackling some things about what is (not) done with submodules yet.
Surely the effort is appreciated.
>> This comment goes to the issue Pierre raised last night as well.
>
> You mean the git checkout issue?
Oh, no; that misuse of parse_opt() that forgot KEEP_DASHDASH one was not
what I had in mind. I meant to say that your "switch branches between an
old pre-submodule rev and a new one that has a submodule at where a blob
or directory used to be" issue with a good explanation material was a good
starting point for submodule improvements for the next cycle.
I'd like the release schedule not too heavily based on "per feature", but
more time-based.
next prev parent reply other threads:[~2008-07-23 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 6:09 [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability Junio C Hamano
2008-07-20 6:09 ` [PATCH v2 2/4] git-add --all: add all files Junio C Hamano
2008-07-20 6:09 ` [PATCH v2 3/4] git-add --all: tests Junio C Hamano
2008-07-20 6:09 ` [PATCH v2 4/4] git-add --all: documentation Junio C Hamano
2008-07-21 0:56 ` [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability Johannes Schindelin
2008-07-21 0:58 ` [PATCH/RFC] git add: do not add files from a submodule Johannes Schindelin
2008-07-22 21:32 ` Johannes Schindelin
2008-07-23 6:40 ` Junio C Hamano
2008-07-23 8:13 ` Pierre Habouzit
2008-07-23 18:31 ` Junio C Hamano [this message]
2008-07-23 19:02 ` Pierre Habouzit
2008-07-23 19:10 ` Johannes Schindelin
2008-07-23 19:11 ` Pierre Habouzit
2008-07-21 5:22 ` [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability Junio C Hamano
2008-07-21 7:52 ` Junio C Hamano
2008-07-21 8:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wvse9l7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).