From: Junio C Hamano <gitster@pobox.com>
To: "Adeodato Simó" <dato@net.com.org.es>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add a commit.signoff configuration variable to always use --signoff
Date: Sat, 27 Dec 2008 03:53:47 -0800 [thread overview]
Message-ID: <7v8wq1esvo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1230368596-6865-1-git-send-email-dato@net.com.org.es> (Adeodato Simó's message of "Sat, 27 Dec 2008 10:03:16 +0100")
Adeodato Simó <dato@net.com.org.es> writes:
> +commit.signoff::
> + If set, 'git commit' will behave as if '-s' option was given.
> + Please use this option with care: by enabling it, you're stating
> + that all your commits will invariably meet the S-o-b
> + requirements for any project you send patches to. It's probably
This is true only if you set it in your global configuration. A more sane
usage would be to have it per repository as you recommend in a later
sentence, and "for any project" part is untrue when the reader does so.
> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
> index b5d81be..abab839 100644
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -96,7 +96,8 @@ OPTIONS
> -s::
> --signoff::
> Add Signed-off-by line by the committer at the end of the commit
> - log message.
> + log message. This overrides the `commit.signoff` configuration
> + variable.
Good and careful thinking. I like it.
next prev parent reply other threads:[~2008-12-27 11:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 12:56 [PATCH] Add a commit.signoff configuration variable to always use --signoff Adeodato Simó
2008-12-26 22:02 ` Nanako Shiraishi
2008-12-26 22:10 ` Adeodato Simó
2008-12-27 0:36 ` Junio C Hamano
2008-12-27 8:26 ` Adeodato Simó
2008-12-27 8:44 ` Junio C Hamano
2008-12-27 9:03 ` Adeodato Simó
2008-12-27 11:04 ` Thomas Rast
2008-12-27 11:05 ` Adeodato Simó
2008-12-27 11:53 ` Junio C Hamano [this message]
2008-12-27 12:01 ` Adeodato Simó
2008-12-29 11:16 ` [PATCH v3] Add a commit.signoff configuration option to always use --signoff in commit Adeodato Simó
2008-12-29 11:18 ` Adeodato Simó
2008-12-30 21:04 ` Junio C Hamano
2009-01-01 22:18 ` Adeodato Simó
2009-01-02 12:46 ` Adeodato Simó
2008-12-27 18:08 ` [PATCH] Add a commit.signoff configuration variable to always use --signoff Jan Krüger
2008-12-27 18:40 ` Adeodato Simó
2008-12-27 19:15 ` Jan Krüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8wq1esvo.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dato@net.com.org.es \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).