git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] merge-recursive: Fix multiple file rename across D/F conflict
Date: Wed, 18 Aug 2010 16:17:27 -0700	[thread overview]
Message-ID: <7v8w438q9k.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1282089199-17253-3-git-send-email-newren@gmail.com> (Elijah Newren's message of "Tue\, 17 Aug 2010 17\:53\:19 -0600")

Elijah Newren <newren@gmail.com> writes:

> I'm really embarrased about this one...  :-/

Let's embarrass you even more ;-)

After 5a2580d, the merge has become very noisy, and I don't see a good
reason for that change.

With a version of git built from 5a2580d^, for example, merging
sp/fix-smart-http-deadlock-on-error into maint would give me this:

----------------
$ git merge sp/fix-smart-http-deadlock-on-error
Auto-merging remote-curl.c
Merge made by recursive.
 remote-curl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------

With 5a2580d, it has become this:

----------------
$ git merge sp/fix-smart-http-deadlock-on-error
Adding builtin/add.c
Auto-merging remote-curl.c
Merge made by recursive.
 remote-curl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------

And with this patch on top, it will make it a disaster:

----------------
$ git merge sp/fix-smart-http-deadlock-on-error
Adding builtin/add.c
... similar 97 Adding lines omitted ...
Adding gitweb/static/gitweb.js
Auto-merging remote-curl.c
Adding t/lib-t6000.sh
Adding t/t7810-grep.sh
Adding t/t9350-fast-export.sh
Merge made by recursive.
 remote-curl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------

  parent reply	other threads:[~2010-08-18 23:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17 23:53 [PATCH 0/2] Fix multiple file rename across D/F conflict Elijah Newren
2010-08-17 23:53 ` [PATCH 1/2] t6031: Add a testcase covering multiple renames across a " Elijah Newren
2010-08-17 23:53 ` [PATCH 2/2] merge-recursive: Fix multiple file rename across " Elijah Newren
2010-08-18 19:00   ` Junio C Hamano
2010-08-18 23:17   ` Junio C Hamano [this message]
2010-08-20 12:47     ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8w438q9k.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).