git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: Thomas Rast <trast@student.ethz.ch>, Git List <git@vger.kernel.org>
Subject: Re: XDL_FAST_HASH breaks git on OS X 10.7.3
Date: Mon, 30 Apr 2012 21:39:13 -0700	[thread overview]
Message-ID: <7v8vhccy6m.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <3BE9DFB5-81F9-40D6-A637-6C3C232394A6@gernhardtsoftware.com> (Brian Gernhardt's message of "Mon, 30 Apr 2012 22:13:09 -0400")

Brian Gernhardt <brian@gernhardtsoftware.com> writes:

> On Apr 30, 2012, at 12:38 PM, Thomas Rast wrote:
>
>> I can reproduce this.  The problem is that __WORDSIZE is not defined,
>> either because it's Darwin or because the GCC is too old.  It winds up
>> compiling the 32-bit case, which of course doesn't work for 64-bit
>> builds.
>
> Great.  I was worried about having to help you debug it via e-mail round-trips.  :-D
>
>> Perhaps we can rewrite it in terms of sizeof(long) like this?
>
> It does work for me, and seems pretty valid to me since long is actually
> the type you're storing it in.

Thomas, care to roll an incremental update with proper log message, so
that we can unbreak the tip of 'next' for Darwin users?

Thanks, both.

  reply	other threads:[~2012-05-01  4:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29 20:52 XDL_FAST_HASH breaks git on OS X 10.7.3 Brian Gernhardt
2012-04-30 16:38 ` Thomas Rast
2012-05-01  2:13   ` Brian Gernhardt
2012-05-01  4:39     ` Junio C Hamano [this message]
2012-05-01  4:41       ` Junio C Hamano
2012-05-01  8:36         ` [PATCH] Choose XDL_FAST_HASH code on sizeof(long) instead of __WORDSIZE Thomas Rast
2012-05-01 17:33           ` Junio C Hamano
2012-05-01  5:32   ` XDL_FAST_HASH breaks git on OS X 10.7.3 David Aguilar
2012-05-01  6:17     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v8vhccy6m.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).