From: Junio C Hamano <gitster@pobox.com>
To: Olaf Klischat <olaf.klischat@gmail.com>
Cc: git@vger.kernel.org, olaf@sofd.de
Subject: Re: [PATCH 0/2] git-add: -s flag (silently ignore files)
Date: Mon, 01 Oct 2012 11:32:03 -0700 [thread overview]
Message-ID: <7v8vbqcacc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1349075700-26334-1-git-send-email-olaf.klischat@gmail.com> (Olaf Klischat's message of "Mon, 1 Oct 2012 09:14:58 +0200")
Olaf Klischat <olaf.klischat@gmail.com> writes:
> ... scenarios where you want to feed the file list into git add
> via find or other external commands (`find .... | xargs git add'),
> which you wouldn't want to carefully tune...
Can you explain this kind of thing in the actual commit log message
when you reroll (if you will do so)?
I also cannot help but find that `scenario` an artificially made-up
one. The description did not feel convincing enough, even if it
were in the proposed commit log message, to justify such an option.
A few questions.
- What were the kind of patterns useful in the above `find` in your
real life example?
- The use of `find` means giving pathspecs from the command line,
e.g. "git add foo/ \*.rb", wouldn't have been sufficient. Are
there something we could improve this in more direct way?
- Why was it too cumbersome to add the idiomatic
\( -name '*.o' -o -name '*~' \) -prune -o
or something like that in front of whatever patterns were used?
- Perhaps a filter that takes a list of paths and emits only the
ignored paths (or only the unignored paths) would be a more
generic approach? You could feed the output from `find` to such
a filter, and then drive not just "git add" but other commands
that take paths if you solved it that way.
prev parent reply other threads:[~2012-10-01 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 7:14 [PATCH 0/2] git-add: -s flag (silently ignore files) Olaf Klischat
2012-10-01 7:14 ` [PATCH 1/2] git-add: -s flag added " Olaf Klischat
2012-10-01 17:59 ` Junio C Hamano
2012-10-01 18:04 ` Matthieu Moy
2012-10-01 7:15 ` [PATCH 2/2] git-add: -s flag: documentation added Olaf Klischat
2012-10-01 18:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vbqcacc.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=olaf.klischat@gmail.com \
--cc=olaf@sofd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).