Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

[Junio C Hamano <gitster@pobox.com>]

Phil Hord <phil.hord@gmail.com> writes:

> On Fri, May 24, 2013 at 5:37 AM, Ramkumar Ramachandra
> <artagnon@gmail.com> wrote:
>> Junio C Hamano wrote:
>>> [...]
>>
>> I agree with the other comments, and have made suitable changes.
>> Let's review your block now.
>>
>>>         This transformation is used to find filepairs that represent
>>>         two kinds of changes, and is controlled by the -S, -G and
>>>         --pickaxe-all options.
>>
>> Why do you call this a "transformation"?  Is git log --author="foo" a
>> transformation on the git-log output?  Then how is git log -Sfoo a
>> transformation?
>>
>> Two kinds of changes controlled by three different options?  Isn't the
>> original much clearer?
>
> They are all three filters.  They transform the output by limiting it
> to commits which meet specific conditions.  Transformation is used in
> the network-graphs sense of the word.  It fits the beginning of the
> document where it says this:
>
>   The diffcore mechanism is fed a list of such comparison results
>   (each of which is called "filepair", although at this point each
>   of them talks about a single file), and transforms such a list
>   into another list.  There are currently 5 such transformations:
>
>   - diffcore-break
>   - diffcore-rename
>   - diffcore-merge-broken
>   - diffcore-pickaxe
>   - diffcore-order

Thanks.