From: Junio C Hamano <gitster@pobox.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: "Aaron Schrab" <aaron@schrab.com>,
git@vger.kernel.org, "David Aguilar" <davvid@gmail.com>,
"Petr Baudis" <pasky@ucw.cz>,
"Richard Hartmann" <richih.mailinglist@gmail.com>,
"Jeff King" <peff@peff.net>,
"Daniel Knittl-Frank" <knittl89@googlemail.com>,
"Jan Krüger" <jk@jk.gs>, "Alejandro Mery" <amery@geeks.cl>
Subject: Re: [PATCH v3] config: add support for http.<url>.* settings
Date: Sun, 14 Jul 2013 21:02:19 -0700 [thread overview]
Message-ID: <7v8v18fp2s.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <47B58075-3FDD-48E5-9047-8650F7FC5E3B@gmail.com> (Kyle J. McKay's message of "Sat, 13 Jul 2013 12:46:17 -0700")
"Kyle J. McKay" <mackyle@gmail.com> writes:
> On Jul 12, 2013, at 13:58, Aaron Schrab wrote:
> ...
> This should guarantee a match in the scenario Aaron proposes above and
> still has pretty much the same easy explanation to the user.
>
> Shall I go ahead and add that to the next patch version?
>
> Or proceed with what's there right now (there are a few pending
> updates from reviewers) and then, as Junio says above, adjust it later
> if needed?
I have been assuming that "strictly textual match" will be a subset
of the matching semantics Aaron and Peff suggested. That is, if we
include your version in the upcoming release, the user writes the
http.<URLpattern>.<variable> configuration so that the entries match
what they want them to match, the enhanced URL matcher Aaron and
Peff suggested will still make them match.
Am I mistaken? Will there be some <URLpattern> that will not match
with the same URL literally?
Assuming that Aaron and Peff's enhancement will not be a backward
incompatible update, my preference is to take the posted matching
semantics as-is (you may have some other changes that does not
change the "strictly textual match" semantics).
I do not have strong opinion but Aaron and Peff seem to know what
they are talking about, so they will be a better guide to work with
you and polish such enhancement on top of what you have now, as a
separate change that may need more time to mature.
next prev parent reply other threads:[~2013-07-15 4:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 21:50 [PATCH v3] config: add support for http.<url>.* settings Kyle J. McKay
2013-07-11 23:12 ` Junio C Hamano
[not found] ` <455666C5-7663-4361-BF34-378D3EAE2891@gmail.com>
[not found] ` <7vsizjn390.fsf@alter.siamese.dyndns.org>
[not found] ` <7v4nbyic57.fsf@alter.siamese.dyndns.org>
2013-07-13 19:46 ` Kyle J. McKay
2013-07-15 4:02 ` Junio C Hamano [this message]
2013-07-15 5:12 ` Jeff King
2013-07-15 9:50 ` Kyle J. McKay
2013-07-15 5:06 ` Jeff King
2013-07-12 9:59 ` Jeff King
2013-07-12 13:07 ` Kyle J. McKay
2013-07-12 20:58 ` Aaron Schrab
2013-07-15 4:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8v18fp2s.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=aaron@schrab.com \
--cc=amery@geeks.cl \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=jk@jk.gs \
--cc=knittl89@googlemail.com \
--cc=mackyle@gmail.com \
--cc=pasky@ucw.cz \
--cc=peff@peff.net \
--cc=richih.mailinglist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).