From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: git-* in test scripts Date: Thu, 28 Aug 2008 17:04:46 -0700 Message-ID: <7v7ia0d6u9.fsf@gitster.siamese.dyndns.org> References: <7BC51BEC-E230-48C5-BD3E-2CECE3C7FC98@cs.indiana.edu> <20080828195211.GA3545@mithlond.arda.local> <4B9831F7-3CB8-49CB-A1DB-111481A271FE@cs.indiana.edu> <20080828212346.GA27867@coredump.intra.peff.net> <1C144B19-DA21-4CB4-B872-C1F154B031CF@cs.indiana.edu> <20080828215907.GE27867@coredump.intra.peff.net> <3DE083DB-ADFF-45E7-B3EB-A76985941271@cs.indiana.edu> <20080828230401.GC29609@coredump.intra.peff.net> <7vmyiwd8ot.fsf@gitster.siamese.dyndns.org> <20080828234151.GG29609@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Jeff King X-From: git-owner@vger.kernel.org Fri Aug 29 02:06:04 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYrV0-0003va-MM for gcvg-git-2@gmane.org; Fri, 29 Aug 2008 02:05:59 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482AbYH2AEy (ORCPT ); Thu, 28 Aug 2008 20:04:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753732AbYH2AEy (ORCPT ); Thu, 28 Aug 2008 20:04:54 -0400 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:43529 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753007AbYH2AEy (ORCPT ); Thu, 28 Aug 2008 20:04:54 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id A292B6C6AD; Thu, 28 Aug 2008 20:04:51 -0400 (EDT) Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 46FF46C6AC; Thu, 28 Aug 2008 20:04:47 -0400 (EDT) In-Reply-To: <20080828234151.GG29609@coredump.intra.peff.net> (Jeff King's message of "Thu, 28 Aug 2008 19:41:51 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 1A0E9A30-755E-11DD-A3E4-3113EBD4C077-77302942!a-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Jeff King writes: > On Thu, Aug 28, 2008 at 04:24:50PM -0700, Junio C Hamano wrote: > >> Test scripts are executed in a special environment whose GIT_EXEC_PATH >> points at the top of the build tree, where all git-foo lives. > > I am not sure how GIT_EXEC_PATH is relevant. We put the git top-level > directory in the PATH, which is why "git-foo" works at all in the test > scripts. But the install by default does _not_ put those commands in > the PATH. So the test scripts serve as a poor example of how to use > git. The commands contained within them would not run in an ordinary git > installation. Well, I was merely replying to your message. If you admit that tests are special and a poor example, why did you bring it up? ;-)