From: Junio C Hamano <gitster@pobox.com>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH v7 3/3] git-remote-ext
Date: Wed, 13 Oct 2010 16:32:38 -0700 [thread overview]
Message-ID: <7v7hhlhdnt.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1286901583-30088-4-git-send-email-ilari.liusvaara@elisanet.fi> (Ilari Liusvaara's message of "Tue\, 12 Oct 2010 19\:39\:43 +0300")
Ilari Liusvaara <ilari.liusvaara@elisanet.fi> writes:
> +'%G<repository>' (as argument)::
> + This argument will not be passed to 'program'. Instead, it
> + will cause helper to start by sending git:// service request to
> + remote side with service field set to approiate value and
> + repository field set to <repository>. Default is not to send
> + such request.
> ++
> +This is useful if remote side is git:// server accessed over
> +some tunnel.
> +
> +'%V<host>' (as argument)::
> + This argument will not be passed to 'program'. Instead it sets
> + the vhost field in git:// service request. Default is not to
> + send vhost in such request (if sent).
The above does not say anything about being the first 'character' in an
argument, like the in-code comment does. Is that intended?
> +static const char **parse_argv(const char *arg, const char *service)
> +{
> + int arguments = 0;
> + int i;
> + const char **ret;
> + char *temparray[MAXARGUMENTS + 1];
> +
> + while (*arg) {
> + char *expanded;
> + if (arguments == MAXARGUMENTS)
> + die("remote-ext command has too many arguments");
> + expanded = strip_escapes(arg, service, &arg);
> + if (expanded)
> + temparray[arguments++] = expanded;
> + }
> +
> + ret = xmalloc((arguments + 1) * sizeof(char *));
> + for (i = 0; i < arguments; i++)
> + ret[i] = temparray[i];
> + ret[arguments] = NULL;
> + return (const char **)ret;
> +}
Isn't "ret" declared to be of that type?
next prev parent reply other threads:[~2010-10-13 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 16:39 [RFC PATCH v7 0/3] git-remote-fd & git-remote-ext Ilari Liusvaara
2010-10-12 16:39 ` [RFC PATCH v7 1/3] Add bidirectional_transfer_loop() Ilari Liusvaara
2010-10-12 16:39 ` [RFC PATCH v7 2/3] git-remote-fd Ilari Liusvaara
2010-10-13 23:33 ` Junio C Hamano
2010-10-12 16:39 ` [RFC PATCH v7 3/3] git-remote-ext Ilari Liusvaara
2010-10-13 23:32 ` Junio C Hamano [this message]
2011-01-16 3:49 ` [PATCH] remote-ext: do not segfault for blank lines Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7hhlhdnt.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).