From: Junio C Hamano <gitster@pobox.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH v7 0/3] some enhancements for reporting branch tracking info
Date: Sun, 18 Aug 2013 12:51:56 -0700 [thread overview]
Message-ID: <7v7gfiojz7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <cover.1376618877.git.worldhello.net@gmail.com> (Jiang Xin's message of "Fri, 16 Aug 2013 10:29:31 +0800")
Jiang Xin <worldhello.net@gmail.com> writes:
> Changes since v6:
>
> * s/broken/gone/ in [PATCH 2/3] (branch: mark missing tracking branch
> as gone)
>
> * rewrite commit log for [PATCH 3/3] (status: always show tracking
> branch even no change)
>
> Jiang Xin (3):
> branch: not report invalid tracking branch
> branch: mark missing tracking branch as gone
> status: always show tracking branch even no change
>
> builtin/branch.c | 36 ++++++++++++--------
> remote.c | 72 +++++++++++++++++++++++++--------------
> t/t6040-tracking-info.sh | 89 +++++++++++++++++++++++++++++++++++++++++++++---
> wt-status.c | 26 +++++++++++---
> 4 files changed, 175 insertions(+), 48 deletions(-)
Thanks; getting clearer to read.
I however feel that [1/3] is introducing a regression (what we used
to report, gone branches, are hidden), only to correct the
regression immediately after it with [2/3].
I wonder if these patches should be combined into one, with
justification like "with the current code, a branch that is in sync
with its upstream, a branch whose upstream no longer exists and a
branch that does not build on anything else cannot be distinguished;
show the first class as 'same', mark the second class as 'gone', and
show only the last one as not having any uptream', or something.
next prev parent reply other threads:[~2013-08-18 19:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 15:42 [RFC] status: show tracking branch even no difference Jiang Xin
2013-08-07 15:50 ` Matthieu Moy
2013-08-07 16:03 ` Jiang Xin
2013-08-08 5:40 ` [PATCH v2] status: always show tracking branch even no change Jiang Xin
2013-08-08 14:49 ` [PATCH v3] " Jiang Xin
2013-08-08 14:49 ` Jiang Xin
2013-08-09 21:18 ` Junio C Hamano
2013-08-10 15:05 ` Jiang Xin
2013-08-12 6:15 ` Junio C Hamano
2013-08-13 4:49 ` Jiang Xin
2013-08-13 4:53 ` [PATCH v5 1/2] branch: not report invalid tracking branch Jiang Xin
2013-08-14 15:21 ` Junio C Hamano
2013-08-15 2:14 ` Jiang Xin
2013-08-14 15:38 ` Junio C Hamano
2013-08-15 18:11 ` [PATCH v6 1/3] " Jiang Xin
2013-08-15 18:11 ` [PATCH v6 2/3] branch: report invalid tracking branch as broken Jiang Xin
2013-08-15 18:38 ` Junio C Hamano
2013-08-15 22:54 ` Junio C Hamano
2013-08-16 2:29 ` [PATCH v7 0/3] some enhancements for reporting branch tracking info Jiang Xin
2013-08-18 19:51 ` Junio C Hamano [this message]
2013-08-19 0:38 ` Jiang Xin
2013-08-26 7:02 ` [PATCH v8 0/2] " Jiang Xin
2013-08-26 7:21 ` Junio C Hamano
2013-08-26 7:02 ` [PATCH v8 1/2] branch: report invalid tracking branch as gone Jiang Xin
2013-08-26 7:02 ` [PATCH v8 2/2] status: always show tracking branch even no change Jiang Xin
2013-08-26 7:47 ` Jeremy Rosen
2013-08-26 8:04 ` Jiang Xin
2013-08-26 16:08 ` Junio C Hamano
[not found] ` <cover.1376620130.git.worldhello.net@gmail.com>
2013-08-16 2:29 ` [PATCH v7 1/3] branch: not report invalid tracking branch Jiang Xin
2013-08-16 2:29 ` [PATCH v7 2/3] branch: mark missing tracking branch as gone Jiang Xin
2013-08-21 7:37 ` Matthieu Moy
2013-08-22 0:00 ` Jiang Xin
2013-08-16 2:29 ` [PATCH v7 3/3] status: always show tracking branch even no change Jiang Xin
2013-08-15 18:11 ` [PATCH v6 " Jiang Xin
2013-08-15 22:56 ` Junio C Hamano
2013-08-13 4:53 ` [PATCH v5 2/2] " Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7gfiojz7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).