* [PATCH] Add "--sign" option to git-format-patch-script
@ 2005-08-12 13:32 Johannes Schindelin
2005-08-12 15:34 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Schindelin @ 2005-08-12 13:32 UTC (permalink / raw
To: git
This adds the option "--sign" to git-format-patch-script which adds
a Signed-off-by: line automatically.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
git-format-patch-script | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
a72d370d43c397238a26c1c7f260a3fd6401f4e6
diff --git a/git-format-patch-script b/git-format-patch-script
--- a/git-format-patch-script
+++ b/git-format-patch-script
@@ -6,7 +6,7 @@
. git-sh-setup-script || die "Not a git archive."
usage () {
- echo >&2 "usage: $0"' [-n] [-o dir] [--mbox] [--check] [-<diff options>...] upstream [ our-head ]
+ echo >&2 "usage: $0"' [-n] [-o dir] [--mbox] [--check] [--sign] [-<diff options>...] upstream [ our-head ]
Prepare each commit with its patch since our-head forked from upstream,
one file per patch, for e-mail submission. Each output file is
@@ -46,6 +46,8 @@ do
date=t author=t mbox=t ;;
-n|--n|--nu|--num|--numb|--numbe|--number|--numbere|--numbered)
numbered=t ;;
+ -s|--s|--si|--sig|--sign)
+ signoff=t ;;
-o=*|--o=*|--ou=*|--out=*|--outp=*|--outpu=*|--output=*|--output-=*|\
--output-d=*|--output-di=*|--output-dir=*|--output-dire=*|\
--output-direc=*|--output-direct=*|--output-directo=*|\
@@ -174,6 +176,14 @@ Date: '"$ad"
b body'
sed -ne "$mailScript" <$commsg
+
+ test "$signoff" = "t" && {
+ offsigner=`git-var GIT_COMMITTER_IDENT | sed -e 's/>.*/>/'`
+ echo
+ echo "Signed-off-by: $offsigner"
+ echo
+ }
+
echo '---'
echo
git-diff-tree -p $diff_opts "$commit" | git-apply --stat --summary
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add "--sign" option to git-format-patch-script
2005-08-12 13:32 [PATCH] Add "--sign" option to git-format-patch-script Johannes Schindelin
@ 2005-08-12 15:34 ` Junio C Hamano
2005-08-12 15:56 ` Daniel Barkalow
2005-08-12 16:05 ` Johannes Schindelin
0 siblings, 2 replies; 5+ messages in thread
From: Junio C Hamano @ 2005-08-12 15:34 UTC (permalink / raw
To: Johannes Schindelin; +Cc: git
Good intentions, but I'd rather see these S-O-B lines in the
actual commit objects. Giving format-patch this option would
discourage people to do so. Maybe a patch to git commit would
be more appropriate, methinks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add "--sign" option to git-format-patch-script
2005-08-12 15:34 ` Junio C Hamano
@ 2005-08-12 15:56 ` Daniel Barkalow
2005-08-12 16:05 ` Johannes Schindelin
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Barkalow @ 2005-08-12 15:56 UTC (permalink / raw
To: Junio C Hamano; +Cc: Johannes Schindelin, git
On Fri, 12 Aug 2005, Junio C Hamano wrote:
> Good intentions, but I'd rather see these S-O-B lines in the
> actual commit objects. Giving format-patch this option would
> discourage people to do so. Maybe a patch to git commit would
> be more appropriate, methinks.
Maybe also something in format-patch to check that the commit has one? I,
at least, tend to have unsigned commits for tracking stuff I've done but
not cleaned up and signed ones that I want to send off as patches. I've
confused the branches on occasion, although never when sending stuff, and
it would be nice to have format-patch tell you if the commit didn't look
right.
-Daniel
*This .sig left intentionally blank*
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add "--sign" option to git-format-patch-script
2005-08-12 15:34 ` Junio C Hamano
2005-08-12 15:56 ` Daniel Barkalow
@ 2005-08-12 16:05 ` Johannes Schindelin
2005-08-12 16:28 ` Junio C Hamano
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Schindelin @ 2005-08-12 16:05 UTC (permalink / raw
To: Junio C Hamano; +Cc: git
Hi,
On Fri, 12 Aug 2005, Junio C Hamano wrote:
> Good intentions, but I'd rather see these S-O-B lines in the
> actual commit objects. Giving format-patch this option would
> discourage people to do so. Maybe a patch to git commit would
> be more appropriate, methinks.
Maybe in addition to this one? I meant that option to be for on-passers of
commits they are not author of.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add "--sign" option to git-format-patch-script
2005-08-12 16:05 ` Johannes Schindelin
@ 2005-08-12 16:28 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2005-08-12 16:28 UTC (permalink / raw
To: Johannes Schindelin; +Cc: git, Daniel Barkalow
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi,
>
> On Fri, 12 Aug 2005, Junio C Hamano wrote:
>
>> Good intentions, but I'd rather see these S-O-B lines in the
>> actual commit objects. Giving format-patch this option would
>> discourage people to do so. Maybe a patch to git commit would
>> be more appropriate, methinks.
>
> Maybe in addition to this one? I meant that option to be for on-passers of
> commits they are not author of.
Surely. Also I find Daniel's suggestion to check a good one.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-08-12 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-12 13:32 [PATCH] Add "--sign" option to git-format-patch-script Johannes Schindelin
2005-08-12 15:34 ` Junio C Hamano
2005-08-12 15:56 ` Daniel Barkalow
2005-08-12 16:05 ` Johannes Schindelin
2005-08-12 16:28 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).