From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.176.0/21 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 From: Junio C Hamano Subject: Re: [BUG] daemon.c blows up on OSX Date: Wed, 20 Dec 2006 15:30:50 -0800 Message-ID: <7v64c65emt.fsf@assigned-by-dhcp.cox.net> References: <7vmz5ib8eu.fsf@assigned-by-dhcp.cox.net> <86vek6z0k2.fsf@blue.stonehenge.com> <86irg6yzt1.fsf_-_@blue.stonehenge.com> <7vr6uu6w8e.fsf@assigned-by-dhcp.cox.net> <86ejquyz4v.fsf@blue.stonehenge.com> <86ac1iyyla.fsf@blue.stonehenge.com> <86wt4mximh.fsf@blue.stonehenge.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii NNTP-Posting-Date: Wed, 20 Dec 2006 23:31:33 +0000 (UTC) Cc: Junio C Hamano , git@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Envelope-to: gcvg-git@gmane.org In-Reply-To: <86wt4mximh.fsf@blue.stonehenge.com> (Randal L. Schwartz's message of "20 Dec 2006 15:17:10 -0800") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Received: from vger.kernel.org ([209.132.176.167]) by dough.gmane.org with esmtp (Exim 4.50) id 1GxAuH-0007Tq-Tn for gcvg-git@gmane.org; Thu, 21 Dec 2006 00:31:30 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161018AbWLTXaz (ORCPT ); Wed, 20 Dec 2006 18:30:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161017AbWLTXaz (ORCPT ); Wed, 20 Dec 2006 18:30:55 -0500 Received: from fed1rmmtao03.cox.net ([68.230.241.36]:43790 "EHLO fed1rmmtao03.cox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161015AbWLTXay (ORCPT ); Wed, 20 Dec 2006 18:30:54 -0500 Received: from fed1rmimpo01.cox.net ([70.169.32.71]) by fed1rmmtao03.cox.net (InterMail vM.6.01.06.03 201-2131-130-104-20060516) with ESMTP id <20061220233051.EGGG29122.fed1rmmtao03.cox.net@fed1rmimpo01.cox.net>; Wed, 20 Dec 2006 18:30:51 -0500 Received: from assigned-by-dhcp.cox.net ([68.5.247.80]) by fed1rmimpo01.cox.net with bizsmtp id 1BW91W00P1kojtg0000000; Wed, 20 Dec 2006 18:30:09 -0500 To: merlyn@stonehenge.com (Randal L. Schwartz) Sender: git-owner@vger.kernel.org merlyn@stonehenge.com (Randal L. Schwartz) writes: > But yes, _XOPEN_SOURCE_EXTENDED definitely does some damage to > curses.h. However, I don't see how that's relevant to strings.h > or the others I need. There's no "config" for "compatibility". > Welcome to Linux vs Unix. :) > > What I do know is (a) it worked before the header changes and (b) > the patch I just gave you works. If the patch doesn't break others, > can we just leave it in? That would lead to maintenance nightmare in the longer term. We cannot do that unless we know more or less what is going on. Including only some system headers in a random order before feature macros are defined, and doing so in only some source files randomly until it starts compiling, is not a solution maintainable in the longer term. The _EXTENDED stuff is minimally commented that AIX wants it; otherwise we would have been tempted to say, "remove it, if it breaks OSX" without thinking, and would have ended up breaking AIX. No matter what we do, I would really want a clear description of in what way OSX headers are broken and what needs to be done to avoid the breakage in git-compat-util.h where it sets up feature macros and includes system headers.