From: Junio C Hamano <gitster@pobox.com>
To: Carlos Rica <jasampler@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Functions for updating refs.
Date: Tue, 04 Sep 2007 10:52:44 -0700 [thread overview]
Message-ID: <7v642qnwr7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46DD6020.4050401@gmail.com> (Carlos Rica's message of "Tue, 04 Sep 2007 15:39:44 +0200")
Carlos Rica <jasampler@gmail.com> writes:
> diff --git a/refs.c b/refs.c
> index 09a2c87..4fd5065 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -1455,3 +1455,35 @@ int for_each_reflog(each_ref_fn fn, void *cb_data)
> {
> return do_for_each_reflog("", fn, cb_data);
> }
> +
> +int update_ref_or_die(const char *action, const char *refname,
> + const unsigned char *sha1,
> + const unsigned char *oldval, int flags)
> +{
> + static struct ref_lock *lock;
> + lock = lock_any_ref_for_update(refname, oldval, flags);
> + if (!lock)
> + die("Cannot lock the ref '%s'.", refname);
> + if (write_ref_sha1(lock, sha1, action) < 0)
> + die("Cannot update the ref '%s'.", refname);
> + return 0;
> +}
> +
> +int update_ref_or_error(const char *action, const char *refname,
> + const unsigned char *sha1,
> + const unsigned char *oldval, int quiet)
> +{
> + static struct ref_lock *lock;
> + lock = lock_any_ref_for_update(refname, oldval, 0);
> + if (!lock) {
> + if (!quiet)
> + error("Cannot lock the ref '%s'.", refname);
> + return 1;
> + }
> + if (write_ref_sha1(lock, sha1, action) < 0) {
> + if (!quiet)
> + error("Cannot update the ref '%s'.", refname);
> + return 1;
> + }
> + return 0;
> +}
This makes me wonder three things:
- Why doesn't "or_error" side allow "flags" as "or_die" one?
Could the 'quiet' option become part of "flags" perhaps?
- They look quite similar. Is it a good idea to refactor them
further, or they are so small it does not matter?
- Why isn't lock released with unlock_ref()?
next prev parent reply other threads:[~2007-09-04 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 13:39 [PATCH] Functions for updating refs Carlos Rica
2007-09-04 13:45 ` Johannes Schindelin
2007-09-04 14:28 ` Johannes Sixt
2007-09-04 14:58 ` Johannes Schindelin
2007-09-04 15:08 ` Johannes Sixt
2007-09-04 15:29 ` Karl Hasselström
2007-09-04 15:33 ` Johannes Schindelin
2007-09-04 17:52 ` Junio C Hamano [this message]
2007-09-04 23:32 ` Carlos Rica
2007-09-05 0:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v642qnwr7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).