From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
David Aguilar <davvid@gmail.com>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Subject: Re: [PATCH 2/4] remote-helpers: rename tests
Date: Wed, 29 May 2013 11:44:06 -0700 [thread overview]
Message-ID: <7v61y1tymh.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s2-Of=AS9Jg7YAXnZ2346ozWPS4gL5irh0devwpkdBKmQ@mail.gmail.com> (Felipe Contreras's message of "Wed, 29 May 2013 12:56:36 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>>> I do not see how it makes sense to copy how they deviate from us
>>>> back to our codebase, especially if we plan to eventually move some
>>>> of these tests out of contrib/ area, but even without such a plan in
>>>> the future.
>>>
>>> They deviate from us, we deviate from them, whatever. We are a single project,
>>> what more than one project does is more standard.
>>
>> We are a single project, so it is better to consistently follow the
>> local convention established here.
>>
>> If your proposal were to
>>
>> - Convert t/*.sh to end with .t intead, to change the project
>> convention, and
>>
>> - Make contrib/ things also conform to that new convention.
>>
>> it may make some sense to discuss the pros and cons of such a move,
>> but changing only contrib/ has no effect other than making it even
>> less consistent with the rest of the project.
>
> It's already inconsistent with the rest of the project, as they are
> not named tNNNN-foo.sh.
Correct; that is why I said "even less consistent".
> If you want I can give it a try at renaming all the tests in the whole
> project to *.t, but I don't think you are truly interested in finding
> a better extension for our tests.
Again, correct. I do not think it is worth the trouble to renaming
them to *.t at this moment.
Having said that, I suspect that in the very longer term it might
turn out to be a good thing to do (if we want to make our test suite
runnable under other people's tools that expect .t suffix, for
example). But I do not think that is the topic of this patch under
discussion.
next prev parent reply other threads:[~2013-05-29 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 2:38 [PATCH 0/4] remote-helpers: test reorganization Felipe Contreras
2013-05-25 2:38 ` [PATCH 1/4] remote-helpers: generate scripts Felipe Contreras
2013-05-25 2:38 ` [PATCH 2/4] remote-helpers: rename tests Felipe Contreras
2013-05-28 20:05 ` Junio C Hamano
2013-05-29 2:50 ` Felipe Contreras
2013-05-29 17:14 ` Junio C Hamano
2013-05-29 17:56 ` Felipe Contreras
2013-05-29 18:44 ` Junio C Hamano [this message]
2013-05-29 19:32 ` Felipe Contreras
2013-05-25 2:38 ` [PATCH 3/4] remote-helpers: allow direct test execution Felipe Contreras
2013-05-25 2:38 ` [PATCH 4/4] remote-helpers: add exec-path links Felipe Contreras
2013-05-28 20:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v61y1tymh.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).