From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>, "Srb\,
Michal" <michal.srb11@imperial.ac.uk>
Subject: Re: [PATCH] log --format: teach %C(auto,black) to paint it black only on terminals
Date: Mon, 17 Dec 2012 11:34:48 -0800 [thread overview]
Message-ID: <7v4njkmq07.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121217121354.GB21858@sigill.intra.peff.net> (Jeff King's message of "Mon, 17 Dec 2012 07:13:54 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Dec 17, 2012 at 06:44:10PM +0700, Nguyen Thai Ngoc Duy wrote:
>
>> > if (!end)
>> > return 0;
>> > - color_parse_mem(placeholder + 2,
>> > - end - (placeholder + 2),
>> > + if (!memcmp(begin, "auto,", 5)) {
>> > + if (!want_color(-1))
>> > + return end - placeholder + 1;
>>
>> This want_color() checks color.ui and only when color.ui = auto, it
>> bothers to check if the output is tty. I think the document should say
>> that "auto," (or maybe another name because it's not really auto)
>> respects color.ui.
>
> Yeah, that should definitely be documented. I wonder if it should
> actually respect color.diff, which is what "log" usually uses (albeit
> mostly for the diff itself, we have always used it for the graph and for
> the "commit" header of each entry).
I actually do not like this patch very much. The original motive
behind this "auto" thing was to relieve the script writers from
the burden of having to write:
if tty -s
then
warn='%C(red)'
reset='%C(reset)'
else
warn= reset=
fi
fmt="${warn}WARNING: boo${reset} %s"
and instead let them write:
fmt="%C(auto,red)WARNING: boo%C(auto,reset) %s"
but between the two, there is no $cmd.color configuration involved
in the first place. I am not sure what $cmd.color configuration
should take effect---perhaps for a "git frotz" script, we should
allow the script writer to honor frotz.color=(auto,never,always)
configuration, not just ui.color variable.
Also the patch as posted deliberately omits support to honor command
line override --color=(auto,never,always), but it may be more
natural to expect
git show --format='%C(auto,red)%s%C(auto,reset)' --color=never
to defeat the "auto," part the script writer wrote.
Now, such a script would be run by its end users as
$ git frotz --color=never
It has to do its own option parsing before running the underlying
"git show" to decide if it passes "--color=never" from the command
line for that to happen.
But at that point, we are back to the square one. Such a script
would be doing something like:
if cmdline_has_color_flag
then
use_color=... that flag ...
elif git config --get-colorbool frotz.color
then
use_color=--color=always
else
use_color=--color=never
fi
in its early part to decide $use_color, to be used in the call it
makes to "git show" later on:
git show --format="$fmt" $use_color
Adding the logic to decide if %C(...) should be added to $fmt no
longer is an additional burden to the script writer, making the
whole %C(auto,red) machinery of little use.
So...
next prev parent reply other threads:[~2012-12-17 19:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <72BB37CB88C48F4B925365539F1EE46C182613A9@icexch-m3.ic.ac.uk>
2012-12-12 17:35 ` FW: Git log --graph doesn't output color when redirected Srb, Michal
2012-12-13 13:13 ` Jeff King
2012-12-13 15:34 ` Srb, Michal
2012-12-15 3:23 ` Nguyen Thai Ngoc Duy
2012-12-15 10:16 ` Jeff King
2012-12-15 18:30 ` Junio C Hamano
2012-12-17 8:40 ` [PATCH] log --format: teach %C(auto,black) to paint it black only on terminals Junio C Hamano
2012-12-17 11:44 ` Nguyen Thai Ngoc Duy
2012-12-17 12:13 ` Jeff King
2012-12-17 19:34 ` Junio C Hamano [this message]
2012-12-17 19:49 ` Jeff King
2012-12-17 20:03 ` Junio C Hamano
2012-12-17 22:55 ` Jeff King
2012-12-17 22:55 ` [PATCH 1/2] t6006: clean up whitespace Junio C Hamano
2012-12-17 22:59 ` Jeff King
2012-12-17 22:56 ` Jeff King
2012-12-17 22:56 ` [PATCH 2/2] log --format: teach %C(auto,black) to respect color config Jeff King
2012-12-17 12:40 ` [PATCH] log --format: teach %C(auto,black) to paint it black only on terminals Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4njkmq07.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=michal.srb11@imperial.ac.uk \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).