From: Junio C Hamano <gitster@pobox.com>
To: Phil Haack <haacked@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Minor bug in git branch --set-upstream-to adding superfluous branch section to config
Date: Fri, 29 Mar 2013 10:27:47 -0700 [thread overview]
Message-ID: <7v4nfup14c.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAD7mMPW=jr6PaAc50h-Wpf42-UPrn0A5KmisqXNXqqLv78AEgg@mail.gmail.com> (Phil Haack's message of "Fri, 29 Mar 2013 09:29:14 -0700")
Phil Haack <haacked@gmail.com> writes:
> Hello there! Please /cc me with responses as I'm not on the mailing list.
>
> I'm using git version 1.8.1.msysgit.1 and I ran into a very minor issue. It
> doesn't actually seem to affect operations, but I thought I'd report it in case
> someone felt it was worth cleaning up.
I do not think this is limited to "branch --set-whatever".
> If you run the following set of commands:
>
> git checkout -b some-branch
> git push origin some-branch
> git branch --set-upstream-to origin/some-branch
> git branch --unset-upstream some-branch
This step causes the removal of the last variable in a configuration
section, which leaves an empty section. As the code to add a new
variable to the configuration, trying to reuse an existing section
header, does not pay attention to an empty section, you end up with
an empty section, followed by a new one.
Either removal of configuration variable should be taught to remove
the section header when a section becomes empty, or addition of
configuration variable should be taught to notice an empty section
header.
> git branch --set-upstream-to origin/some-branch
>
> You get the following result in the .git\config file
>
> [branch "some-branch"]
> [branch "some-branch"]
> remote = origin
> merge = refs/heads/some-branch
prev parent reply other threads:[~2013-03-29 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 16:29 Minor bug in git branch --set-upstream-to adding superfluous branch section to config Phil Haack
2013-03-29 17:00 ` Jeff King
2013-03-29 17:20 ` Thomas Rast
2013-03-29 17:23 ` Jeff King
2013-03-29 17:50 ` [PATCH] t1300: document some aesthetic failures of the config editor Jeff King
2013-03-29 18:51 ` Junio C Hamano
2013-03-29 19:51 ` Jeff King
2013-03-29 20:35 ` Junio C Hamano
2013-03-30 0:21 ` Jeff King
2018-03-28 16:33 ` Johannes Schindelin
2018-03-28 17:59 ` Jeff King
2013-03-29 20:00 ` Junio C Hamano
2013-03-29 17:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4nfup14c.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=haacked@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).