From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>,
git@vger.kernel.org,
Jorge Juan Garcia Garcia
<Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>
Subject: Re: [PATCH v3 1/2] rm: better error message on failure for multiple files
Date: Mon, 10 Jun 2013 13:55:48 -0700 [thread overview]
Message-ID: <7v4nd5fzxn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqtxl5dfrf.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 10 Jun 2013 19:42:12 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>> +{
>>> + if (files_list->nr) {
>>> + struct strbuf err_msg = STRBUF_INIT;
>>> + int i;
>>> + strbuf_addstr(&err_msg, main_msg);
>>> + for (i = 0; i < files_list->nr; i++)
>>> + strbuf_addf(&err_msg,
>>> + "\n %s",
>>
>> Is there an implication of having always 4 spaces here to l10n/i18n
>> here? I am wondering if it should be _("\n %s").
>
> I'd say this is just formatting and should be the same in every
> languages, but I'm far from an expert in the domain.
After looking at the patch again I do not think 4-SP matters. I was
primarily worried if this was to align with some column of the first
line of output, e.g.
error: lorem ipsum dolor sit amet, consectetur adipisicing
elit, sed do eiusmod tempor incididunt ut labore et
dolore magna aliqua.
but that is not what this 4-SP indent is about, so it is OK.
>> test_expect_success 'rm files with different staged content' '
>> cat >expect <<\-EOF &&
>
> (that should be -\EOF, not \-EOF I think)
Sorry, my bad. You are of course right.
>> (2) by using a dash '-' before the end-of-here-text marker, you can
>> align the body of here text with a leading tab (HT).
>
> This works because the list of files is aligned with spaces, but is
> seems a bit fragile to me to use this -EOF on a text which uses
> indentation. Anyway, I'm fine with both.
True.
next prev parent reply other threads:[~2013-06-10 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 15:59 [PATCH v3 1/2] rm: better error message on failure for multiple files Mathieu Lienard--Mayor
2013-06-10 15:59 ` [PATCH v3 2/2] rm: introduce advice.rmHints to shorten messages Mathieu Lienard--Mayor
2013-06-10 17:25 ` Junio C Hamano
2013-06-10 16:06 ` [PATCH v3 1/2] rm: better error message on failure for multiple files Matthieu Moy
2013-06-10 17:17 ` Junio C Hamano
2013-06-10 17:42 ` Matthieu Moy
2013-06-10 20:55 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-10 16:05 Mathieu Lienard--Mayor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4nd5fzxn.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
--cc=Mathieu.Lienard--Mayor@ensimag.imag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).