git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: benoit.person@ensimag.fr, git@vger.kernel.org,
	Celestin Matte <celestin.matte@ensimag.fr>
Subject: Re: [PATCH v5 5/5] git-remote-mediawiki: Add preview subcommand into git mw.
Date: Thu, 27 Jun 2013 08:22:42 -0700	[thread overview]
Message-ID: <7v4ncjvarh.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpq8v1w39sg.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 26 Jun 2013 22:18:55 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> benoit.person@ensimag.fr writes:
>
>> +do you want ? Use the -r option to specify the remote.
>
> Not that it really matters, but there should be no space before ? in
> English (although there is in French).
>
> (Shouldn't prevent merging)
>
> Other than that, the series looks good to me. Good work splitting
> patches 1 to 4, the history looks much nicer now.

Thanks; queued.

      reply	other threads:[~2013-06-27 15:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 19:12 [PATCH v5 0/5] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-06-26 19:12 ` [PATCH v5 1/5] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person
2013-06-26 19:12 ` [PATCH v5 2/5] git-remote-mediawiki: new git bin-wrapper for developement benoit.person
2013-06-26 19:12 ` [PATCH v5 3/5] git-remote-mediawiki: factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person
2013-06-26 19:12 ` [PATCH v5 4/5] git-remote-mediawiki: Adding git-mw command benoit.person
2013-06-26 19:12 ` [PATCH v5 5/5] git-remote-mediawiki: Add preview subcommand into git mw benoit.person
2013-06-26 20:18   ` Matthieu Moy
2013-06-27 15:22     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v4ncjvarh.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=benoit.person@ensimag.fr \
    --cc=celestin.matte@ensimag.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).