git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@ucw.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	junkio@cox.net, git@vger.kernel.org
Subject: Re: full kernel history, in patchset format
Date: Sat, 16 Apr 2005 12:27:32 -0700	[thread overview]
Message-ID: <7v3btq7c9n.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20050416185751.GJ19099@pasky.ji.cz> (Petr Baudis's message of "Sat, 16 Apr 2005 20:57:51 +0200")

>>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:

PB> P.S.: It seems that Linus applied a patch to ls-tree which will make it
PB> read_sha1_file() on each item when ls-tree is recursive. Junio, why did
PB> you do it?

Sorry it was my misunderstanding, before I found out exactly how
S_ISDIR is used.  Thank you for pointing it out.

I was confused by this comment around the area I changed:

    /* XXX: We do some ugly mode heuristics here.
     * It seems not worth it to read each file just to get this
     * and the file size. -- pasky@ucw.cz

I mistakenly inferred from that comment that S_ISDIR(mode) is
not a guarantee.  So I mistakenly optimized it for non-recursive
case by keeping that "heuristics".  The logic was: If recursive
we will need to run read_sha1_file() to find out if it is really
a tree anyway.

I'll fix it up, now I know S_ISDIR(mode) is a guarantee that it
is a tree, I'll do the "heuristics" first, and do read_sha1_file
only when it is a tree and I am recursive.


  reply	other threads:[~2005-04-16 19:24 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-16 13:15 full kernel history, in patchset format Ingo Molnar
2005-04-16 13:35 ` Ingo Molnar
2005-04-16 14:55   ` David Mansfield
2005-04-16 19:18     ` Ingo Molnar
2005-04-16 15:08 ` Francois Romieu
2005-04-16 17:04 ` Linus Torvalds
2005-04-16 17:43   ` Petr Baudis
2005-04-16 15:44     ` Christopher Li
2005-04-16 18:31   ` Junio C Hamano
2005-04-16 18:35     ` Mike Taht
2005-04-16 19:19       ` Junio C Hamano
2005-04-16 16:26         ` Christopher Li
2005-04-16 19:44           ` Junio C Hamano
2005-04-16 19:42         ` Mike Taht
2005-04-16 20:19           ` Daniel Barkalow
2005-04-16 18:46     ` Junio C Hamano
2005-04-16 19:13   ` Jan-Benedict Glaw
2005-04-16 19:23   ` Thomas Gleixner
2005-04-16 18:32     ` Petr Baudis
2005-04-16 18:36       ` Petr Baudis
2005-04-16 19:41       ` Thomas Gleixner
2005-04-16 18:44     ` Linus Torvalds
2005-04-16 19:50       ` Thomas Gleixner
2005-04-16 18:57         ` Petr Baudis
2005-04-16 19:27           ` Junio C Hamano [this message]
2005-04-16 19:15         ` Linus Torvalds
2005-04-16 20:35           ` Thomas Gleixner
2005-04-16 23:08     ` David Lang
2005-04-16 19:41   ` Ingo Molnar
2005-04-17 23:31   ` David Woodhouse
2005-04-17 23:39     ` Petr Baudis
2005-04-18  0:06       ` David Woodhouse
2005-04-18  0:35         ` Petr Baudis
2005-04-18  0:45           ` David Woodhouse
2005-04-18  0:50             ` Petr Baudis
2005-04-18  0:51               ` David Woodhouse
2005-04-18  0:59                 ` Petr Baudis
2005-04-18  1:16           ` Linus Torvalds
2005-04-18  1:36             ` David Woodhouse
2005-04-18 10:07 ` Catalin Marinas
2005-04-18 22:41   ` David Mansfield
2005-04-19  8:33     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v3btq7c9n.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pasky@ucw.cz \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).