From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <junkio@cox.net>
Subject: Re: gitweb using "--cc"?
Date: Thu, 09 Feb 2006 11:41:36 -0800
Message-ID: <7v3bisb9qn.fsf@assigned-by-dhcp.cox.net>
References: <Pine.LNX.4.64.0602081532360.2458@g5.osdl.org>
	<43EAA560.8030504@didntduck.org>
	<Pine.LNX.4.64.0602081817040.2458@g5.osdl.org>
	<7vu0b9jkad.fsf@assigned-by-dhcp.cox.net>
	<Pine.LNX.4.64.0602090822100.2458@g5.osdl.org>
	<Pine.LNX.4.64.0602091029310.2458@g5.osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Git Mailing List <git@vger.kernel.org>
X-From: git-owner@vger.kernel.org Thu Feb 09 20:42:30 2006
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1F7Hfm-0000v8-5L
	for gcvg-git@gmane.org; Thu, 09 Feb 2006 20:41:46 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750744AbWBITlm (ORCPT <rfc822;gcvg-git@m.gmane.org>);
	Thu, 9 Feb 2006 14:41:42 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750743AbWBITlm
	(ORCPT <rfc822;git-outgoing>); Thu, 9 Feb 2006 14:41:42 -0500
Received: from fed1rmmtao05.cox.net ([68.230.241.34]:53220 "EHLO
	fed1rmmtao05.cox.net") by vger.kernel.org with ESMTP
	id S1750742AbWBITll (ORCPT <rfc822;git@vger.kernel.org>);
	Thu, 9 Feb 2006 14:41:41 -0500
Received: from assigned-by-dhcp.cox.net ([68.4.9.127])
          by fed1rmmtao05.cox.net
          (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP
          id <20060209193917.RKD17838.fed1rmmtao05.cox.net@assigned-by-dhcp.cox.net>;
          Thu, 9 Feb 2006 14:39:17 -0500
To: Linus Torvalds <torvalds@osdl.org>
In-Reply-To: <Pine.LNX.4.64.0602091029310.2458@g5.osdl.org> (Linus Torvalds's
	message of "Thu, 9 Feb 2006 10:30:28 -0800 (PST)")
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/15818>

I was wondering if we could teach not diff_tree_combined_merge
but show_combined_diff to do this, so that diff-files -c would
benefit from the raw output as wel.

That aside, one remaining nit with your patch is printing
p->path.  diff.c::diff_flush_raw() does something like this:

	if (line_termination) {
		path_one = quote_one(path_one);
		path_two = quote_one(path_two);
	}
	...
	printf("%s%c%s", status, inter_name_termination, path_one);

But otherwise from a cursory look the patch appears correct.

Thanks.