From: Junio C Hamano <gitster@pobox.com>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Shawn Pearce <spearce@spearce.org>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] index-pack: Create .keep files with same permissions and .pack/.idx
Date: Fri, 01 Apr 2011 21:21:31 -0700 [thread overview]
Message-ID: <7v39m1e110.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <201104020127.41774.johan@herland.net> (Johan Herland's message of "Sat, 02 Apr 2011 01:27:41 +0200")
Johan Herland <johan@herland.net> writes:
> Hmpf. I didn't know that clone --local --no-hardlinks was unsafe. If it's
> not safe, should it still be the default behavior for a cross-filesystem
> clone?
Unsafe is not quite the right word to use here in the sense that it
wouldn't lead to any repository _corruption_ per-se, but if you ended up
copying such a transient .keep file, the pack will stay forever in your
clone target unless you notice and remove it yourself.
Having said that, I expect that the majority of use of a filesystem level
local clone these days is to clone your own repository, likely on your own
machine, and you have absolute control on both ends (e.g. you wouldn't be
running a repack on the source while running a clone---you would more
likely to see the repack finish and then clone). So in that sense I would
still think that file level clone being the default on a local machine is
a reasonable default.
> While pushing to a remote repo, Git transiently adds a .keep file for the
> pack being pushed, to protect it from a concurrent "git gc". Sometimes, when
> the push fails or is aborted, the .keep file is left stale in the repo. This
> causes problems for other users of the same repo, since the permissions on
> the .keep file (0600) make it inaccessible even though the rest of the repo
> is accessible (0444 modulo shared_repository setting).
I was also wondering why you initialized with 0444 in your patch and then
even adjusted for shared repository settings.
This is a tangent, but wouldn't it be wrong for index-pack to always leave
the idx and pack files in 0444 with an explicit chmod() in the first
place? I suspect that we simply forgot to fix it when we introduced
adjust_shared_perm().
next prev parent reply other threads:[~2011-04-02 4:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 10:46 Problems with stale .keep files on git server Johan Herland
2011-03-31 19:04 ` Jeff King
2011-04-01 1:29 ` [PATCH 1/2] index-pack: Create .keep files with same permissions and .pack/.idx Johan Herland
2011-04-01 21:39 ` Junio C Hamano
2011-04-01 21:41 ` Jeff King
2011-04-01 21:49 ` Shawn Pearce
2011-04-01 22:21 ` Junio C Hamano
2011-04-01 23:27 ` Johan Herland
2011-04-02 4:21 ` Junio C Hamano [this message]
2011-04-03 1:01 ` Johan Herland
2011-04-01 23:37 ` Johan Herland
2011-04-01 1:34 ` [RFC/PATCH 2/2] repack: Remove stale .keep files before repacking Johan Herland
2011-04-01 1:41 ` Jeff King
2011-04-01 8:12 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v39m1e110.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).