From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] am: handle stray $dotest directory
Date: Sun, 16 Jun 2013 19:45:18 -0700 [thread overview]
Message-ID: <7v38shjw01.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1371300192-6222-2-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Sat, 15 Jun 2013 18:13:11 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> else
> + # Possible stray $dotest directory in the independent-run
> + # case; in the --rebasing case, it is upto the caller
> + # (git-rebase--am) to take care of stray directories.
> + if test -d "$dotest" && test -z "$rebasing"
The $rebasing variable is set only when the command line of "git am"
has --rebasing, i.e. only when it is driven by "git rebase". So
this will not affect what happens to "git am --abort" that is run by
the end user. That sounds like a safe thing to do as far as "am" is
concerned.
Will replace what has been queued on 'pu'. Thanks.
next prev parent reply other threads:[~2013-06-17 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 12:43 [PATCH v3 0/2] Fix am with stray $dotest directory Ramkumar Ramachandra
2013-06-15 12:43 ` [PATCH v3 1/2] am: handle " Ramkumar Ramachandra
2013-06-17 2:45 ` Junio C Hamano [this message]
2013-06-17 17:54 ` Junio C Hamano
2013-06-18 7:05 ` Ramkumar Ramachandra
2013-06-18 14:31 ` Junio C Hamano
2013-06-18 14:44 ` Ramkumar Ramachandra
2013-06-15 12:43 ` [PATCH v3 2/2] t/am: use test_path_is_missing() where appropriate Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v38shjw01.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).