From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 05/14] remote: remove dead code in read_branches_file()
Date: Sun, 23 Jun 2013 00:19:17 -0700 [thread overview]
Message-ID: <7v38s9i9ai.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1371887901-5659-6-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Sat, 22 Jun 2013 13:28:12 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> - /*
> - * With "slash", e.g. "git fetch jgarzik/netdev-2.6" when
> - * reading from $GIT_DIR/branches/jgarzik fetches "HEAD" from
> - * the partial URL obtained from the branches file plus
> - * "/netdev-2.6" and does not store it in any tracking ref.
> - * #branch specifier in the file is ignored.
> - *
> - * Otherwise, the branches file would have URL and optionally
> - * #branch specified. The "master" (or specified) branch is
> - * fetched and stored in the local branch of the same name.
> - */
Removal of the second paratraph is wrong, isn't it?
> frag = strchr(p, '#');
> if (frag) {
> *(frag++) = '\0';
> strbuf_addf(&branch, "refs/heads/%s", frag);
> } else
> strbuf_addstr(&branch, "refs/heads/master");
> - if (!slash) {
> - strbuf_addf(&branch, ":refs/heads/%s", remote->name);
> - } else {
> - strbuf_reset(&branch);
> - strbuf_addstr(&branch, "HEAD:");
> - }
> +
> + strbuf_addf(&branch, ":refs/heads/%s", remote->name);
> add_url_alias(remote, p);
> add_fetch_refspec(remote, strbuf_detach(&branch, NULL));
> /*
next prev parent reply other threads:[~2013-06-23 7:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 7:58 [PATCH v2 00/14] Classify {branches,remotes}-file as fringe features Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 01/14] t/t5505-remote: modernize style Ramkumar Ramachandra
2013-06-23 7:42 ` Junio C Hamano
2013-06-23 7:50 ` Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 02/14] t/t5505-remote: test push-refspec in branches-file Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 03/14] t/t5505-remote: use test_path_is_missing Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 04/14] t/t5505-remote: remove dependency on $origin_url Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 05/14] remote: remove dead code in read_branches_file() Ramkumar Ramachandra
2013-06-23 7:19 ` Junio C Hamano [this message]
2013-06-22 7:58 ` [PATCH v2 06/14] t/t5505-remote: test url-with-# in branches-file Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 07/14] t/t5516-fetch-push: don't use branches-file Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 08/14] ls-remote doc: fix example invocation on git.git Ramkumar Ramachandra
2013-06-23 7:22 ` Junio C Hamano
2013-06-23 7:53 ` Ramkumar Ramachandra
2013-06-23 8:04 ` Junio C Hamano
2013-06-22 7:58 ` [PATCH v2 09/14] ls-remote doc: rewrite <repository> paragraph Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 10/14] ls-remote doc: don't encourage use of branches-file Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 11/14] t/t5505-remote: test multiple push/pull in remotes-file Ramkumar Ramachandra
2013-06-23 8:07 ` Junio C Hamano
2013-06-23 8:28 ` Ramkumar Ramachandra
2013-06-23 21:49 ` Junio C Hamano
2013-06-22 7:58 ` [PATCH v2 12/14] t/t5510-fetch: don't use remotes-file Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 13/14] t/t5515-fetch-merge-logic: don't use {branches,remotes}-file Ramkumar Ramachandra
[not found] ` <CA+gHt1B1pKz5iU+9m_gi36u7g91qZqgdkY97WDAWjRGxu-Vjuw@mail.gmail.com>
2013-06-25 10:20 ` Ramkumar Ramachandra
2013-06-22 7:58 ` [PATCH v2 14/14] remote: add comment about read_{branches,remotes}_file Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v38s9i9ai.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).