From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: benoit.person@ensimag.fr, git@vger.kernel.org,
Celestin Matte <celestin.matte@ensimag.fr>
Subject: Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable
Date: Wed, 03 Jul 2013 13:24:46 -0700 [thread overview]
Message-ID: <7v38rve6i9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqfvvvq5bl.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 03 Jul 2013 12:57:18 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> benoit.person@ensimag.fr writes:
>
>> diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh
>> index 53a8dd0..dbebe49 100644
>> --- a/wrap-for-bin.sh
>> +++ b/wrap-for-bin.sh
>> @@ -14,7 +14,7 @@ else
>> GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt'
>> export GIT_TEMPLATE_DIR
>> fi
>> -GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib'
>> +GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib:'"$GITPERLLIB"
>
> Then you need to do something like this to prevent broken $GITPERLLIB in
> user's configuration from interfering with the testsuite:
>
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -92,6 +92,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
> print join("\n", @vars);
> ')
> unset XDG_CONFIG_HOME
> +unset GITPERLLIB
> GIT_AUTHOR_EMAIL=author@example.com
> GIT_AUTHOR_NAME='A U Thor'
> GIT_COMMITTER_EMAIL=committer@example.com
Yes, that is a good point.
It introduces a chicken-and-egg circularity for git-mw tests to use
the common test infrastructure by dot-sourcing this file, though,
no?
next prev parent reply other threads:[~2013-07-03 20:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 22:39 [PATCH v7 0/7] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-07-02 22:39 ` [PATCH v7 1/7] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person
2013-07-02 22:59 ` Junio C Hamano
2013-07-02 22:39 ` [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable benoit.person
2013-07-02 23:01 ` Junio C Hamano
2013-07-02 23:19 ` Benoît Person
2013-07-03 8:54 ` Junio C Hamano
2013-07-03 9:46 ` Benoît Person
2013-07-03 10:30 ` Michael Haggerty
2013-07-03 10:57 ` Matthieu Moy
2013-07-03 20:24 ` Junio C Hamano [this message]
2013-07-03 20:38 ` Matthieu Moy
2013-07-03 21:50 ` Junio C Hamano
2013-07-02 22:39 ` [PATCH v7 3/7] git-remote-mediawiki: New git bin-wrapper for developement benoit.person
2013-07-02 23:04 ` Junio C Hamano
2013-07-02 22:39 ` [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper benoit.person
2013-07-03 9:18 ` Matthieu Moy
2013-07-02 22:39 ` [PATCH v7 5/7] git-remote-mediawiki: Factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person
2013-07-02 22:39 ` [PATCH v7 6/7] git-remote-mediawiki: Adding git-mw command benoit.person
2013-07-02 22:39 ` [PATCH v7 7/7] git-remote-mediawiki: Add preview subcommand into git mw benoit.person
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v38rve6i9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).