git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	"J. Bruce Fields" <bfields@citi.umich.edu>
Subject: Re: [PATCH] new test from the submodule chapter of the user manual
Date: Fri, 21 Sep 2007 11:04:05 -0700	[thread overview]
Message-ID: <7v1wcrki96.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070921130908.GF16235@genesis.frugalware.org> (Miklos Vajna's message of "Fri, 21 Sep 2007 15:09:08 +0200")

That's horrible.  Please do not depend on object SHA1's to stay
the same.  If somebody makes a fix to the test to add a new file
in a sample subproject it would break all the rest.  Also please
do not depend on the progress output.

In short, please do not try to get away with quick-and-dirty.

  reply	other threads:[~2007-09-21 18:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18 10:55 [rfc] git submodules howto Miklos Vajna
2007-09-18 12:03 ` Johannes Schindelin
2007-09-18 12:10 ` Michael Smith
2007-09-18 13:29 ` J. Bruce Fields
2007-09-18 15:47   ` Miklos Vajna
2007-09-18 15:55     ` J. Bruce Fields
2007-09-18 16:11       ` Miklos Vajna
2007-09-18 18:12         ` Michael Smith
2007-09-19 17:42           ` [PATCH] User Manual: add a chapter for submodules Miklos Vajna
2007-09-19 19:44             ` Junio C Hamano
2007-09-19 20:30               ` J. Bruce Fields
2007-09-20  0:01               ` Miklos Vajna
2007-09-20  0:34               ` Miklos Vajna
2007-09-20  4:15                 ` Junio C Hamano
2007-09-20 10:34                   ` Johannes Schindelin
2007-09-20 17:08                     ` [PATCH] new test from the submodule chapter of the user manual Miklos Vajna
2007-09-20 17:59                       ` Joel Becker
2007-09-20 18:47                         ` Johannes Schindelin
2007-09-20 21:46                           ` Miklos Vajna
2007-09-20 22:56                           ` Joel Becker
2007-09-20 21:35                       ` Junio C Hamano
2007-09-21 13:09                         ` Miklos Vajna
2007-09-21 18:04                           ` Junio C Hamano [this message]
2007-09-22 20:05                             ` Miklos Vajna
2007-09-20 22:02                   ` [PATCH] User Manual: add a chapter for submodules Miklos Vajna
2007-09-19 21:00             ` Sven Verdoolaege
2007-09-24  7:11 ` [rfc] git submodules howto Uwe Kleine-König
2007-09-24  8:30   ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v1wcrki96.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bfields@citi.umich.edu \
    --cc=git@vger.kernel.org \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).