From: Junio C Hamano <gitster@pobox.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: git@vger.kernel.org, Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: [PATCH] send-email: Add config option for sender address
Date: Mon, 13 Apr 2009 00:45:34 -0700 [thread overview]
Message-ID: <7v1vrxhu8x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090410093432.6117@nanako3.lavabit.com> (Nanako Shiraishi's message of "Fri, 10 Apr 2009 09:34:32 +0900")
Nanako Shiraishi <nanako3@lavabit.com> writes:
> Quoting Trent Piepho:
>
>> The sender address, as specified with the '--from' command line option,
>> couldn't be set in the config file. So add a new config option,
>> 'sendemail.from', which sets it. One can use 'sendemail.<identity>.from'
>> as well of course, which is likely the more useful case.
>>
>> The sender address would default to GIT_AUTHOR_IDENT, which is usually the
>> right thing, but this doesn't allow switching based on the identity
>> selected. It's possible to switch the SMTP server and envelope sender by
>> using the '--identity' option, in which case one probably wants to use a
>> different from address as well, but this had to be manually specified.
>>
>> The docs are also fixed up somewhat. If '--from' is specified (or the new
>> sendemail.from option is used) then the user isn't prompted. The default
>> with no '--from' option (or sendemail.from option) is GIT_AUTHOR_IDENT
>> first then GIT_COMMITTER_IDENT, not just GIT_COMMITTER_IDENT.
>>
>> Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
>
> Junio, may I ask what happened to this patch?
If I recall correctly, it didn't look too invasive and I found it Ok, but
I didn't see any comments on it, so it was dropped on the floor.
Perhaps Trent cares to resend?
next prev parent reply other threads:[~2009-04-13 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 1:00 [PATCH] send-email: Add config option for sender address Trent Piepho
2009-04-10 0:34 ` Nanako Shiraishi
2009-04-13 7:45 ` Junio C Hamano [this message]
2009-05-12 22:48 ` [PATCH v2] " Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v1vrxhu8x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).