From: "Totsten Bögershausen" <tboegi@web.de>
To: Elijah Newren <newren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: BUG report: unicode normalization on APFS (Mac OS High Sierra)
Date: Fri, 27 Apr 2018 23:45:42 +0200 [thread overview]
Message-ID: <7f9feab0-3638-56cd-18bb-4de0122aabad@web.de> (raw)
In-Reply-To: <CABPp-BHitvta8we8di-tFiNdVV7vXnMNAhiAs2=CrQc-gGuSJw@mail.gmail.com>
On 2018-04-26 19:23, Elijah Newren wrote:
> On Thu, Apr 26, 2018 at 10:13 AM, Torsten Bögershausen <tboegi@web.de> wrote:
>> Hm,
>> thanks for the report.
>> I don't have a high sierra box, but I can probably get one.
>> t0050 -should- pass automagically, so I feel that I can do something.
>> Unless someone is faster of course.
>
> Sweet, thanks for taking a look.
>
>> Is it possible that you run
>> debug=t verbose=t ./t0050-filesystem.sh
>> and send the output to me ?
>
> Sure. First, though, note that I can make it pass (or at least "not
> ok...TODO known breakage") with the following patch (may be
> whitespace-damaged by gmail):
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 483c8d6d7..770b91f8c 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1106,12 +1106,7 @@ test_lazy_prereq UTF8_NFD_TO_NFC '
> auml=$(printf "\303\244")
> aumlcdiar=$(printf "\141\314\210")
> >"$auml" &&
> - case "$(echo *)" in
> - "$aumlcdiar")
> - true ;;
> - *)
> - false ;;
> - esac
> + stat "$aumlcdiar" >/dev/null 2>/dev/null
Nicely analyzed and improved.
The "stat" statement is technically correct.
I think that a more git-style fix would be
[] ---
+ test -r "$aumlcdiar"
instead of the stat.
I looked into the 2 known breakages.
In short: they test use cases which are not sooo important for a user in
practice, but do a good test if the code is broken.
IOW: I can't see a need for immediate action.
As you already did all the analyzes:
Do you want to send a patch ?
next prev parent reply other threads:[~2018-04-27 21:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 16:48 BUG report: unicode normalization on APFS (Mac OS High Sierra) Elijah Newren
2018-04-26 17:13 ` Torsten Bögershausen
2018-04-26 17:23 ` Elijah Newren
2018-04-27 21:45 ` Totsten Bögershausen [this message]
2018-04-30 15:29 ` Elijah Newren
2018-04-30 6:35 ` [PATCH v1 1/1] test: Correct detection of UTF8_NFD_TO_NFC for APFS tboegi
2018-04-30 7:56 ` Junio C Hamano
2018-04-30 8:55 ` Torsten Bögershausen
2018-04-30 15:33 ` Elijah Newren
2018-04-30 15:41 ` Torsten Bögershausen
2018-04-30 15:47 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f9feab0-3638-56cd-18bb-4de0122aabad@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).