From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <l.s.r@web.de>,
git@vger.kernel.org
Subject: Re: Support for --stdin-paths in commit, add, etc
Date: Fri, 2 Aug 2019 13:44:03 +0200 [thread overview]
Message-ID: <7edb3b11-054c-81a9-d88e-7e2325ad813f@syntevo.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1908021335250.46@tvgsbejvaqbjf.bet>
@Johannes, thanks a lot for your tips!
On 02.08.2019 13:40, Johannes Schindelin wrote:
> From past experience, I find that it is important to also implement the
> `-z` option (which traditionally means: accept items via the command
> line that are delimited by NULs).
>
> And you might find inspiration in my patch to read the paths passed to
> `git reset` from stdin:
> https://github.com/gitgitgadget/git/pull/133/commits/1db4ef0ec1ec
>
> I guess you could use a similar approach just after the
> `parse_pathspec()` call in `prepare_index()`:
> https://github.com/gitgitgadget/git/blob/1db4ef0ec1ec/builtin/commit.c#L339-L342
prev parent reply other threads:[~2019-08-02 11:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 15:45 Support for --stdin-paths in commit, add, etc Alexandr Miloslavskiy
2019-07-31 17:15 ` Junio C Hamano
2019-07-31 17:19 ` Jeff King
2019-07-31 21:21 ` Junio C Hamano
2019-08-01 13:25 ` Alexandr Miloslavskiy
2019-08-01 17:35 ` Phillip Wood
2019-08-01 20:26 ` Junio C Hamano
2019-08-01 20:40 ` Alexandr Miloslavskiy
2019-08-02 11:33 ` Johannes Schindelin
2019-08-02 11:45 ` Alexandr Miloslavskiy
2019-08-02 14:48 ` Johannes Schindelin
2019-08-02 14:52 ` Alexandr Miloslavskiy
2019-08-02 11:52 ` Alexandr Miloslavskiy
2019-08-02 14:47 ` Johannes Schindelin
2019-08-02 15:11 ` Alexandr Miloslavskiy
2019-08-01 14:26 ` René Scharfe
2019-08-01 14:33 ` Alexandr Miloslavskiy
2019-08-01 15:56 ` Junio C Hamano
2019-08-01 16:04 ` Alexandr Miloslavskiy
2019-08-01 20:45 ` Junio C Hamano
2019-08-01 20:51 ` Alexandr Miloslavskiy
2019-08-02 11:40 ` Johannes Schindelin
2019-08-02 11:44 ` Alexandr Miloslavskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7edb3b11-054c-81a9-d88e-7e2325ad813f@syntevo.com \
--to=alexandr.miloslavskiy@syntevo.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).