From: "Ben Denhartog" <ben@sudoforge.com>
To: "Jeff King" <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: --no-tags doesn't appear to be working as intended
Date: Sun, 03 May 2020 11:27:10 -0700 [thread overview]
Message-ID: <7ecc6a46-001a-45b5-8b63-7e07f88acfb9@www.fastmail.com> (raw)
In-Reply-To: <20200503065446.GA1829906@coredump.intra.peff.net>
Gah, sorry for the erroneous bug report, this was user error.
This was caused by having `fetch.prunetags = true` in my user-scoped conffile. As per the documentation from `git-fetch`:
```
The --prune-tags option is equivalent to having refs/tags/*:refs/tags/* declared in the refspecs of the remote. This can lead to some seemingly strange interactions:
# These both fetch tags
$ git fetch --no-tags origin 'refs/tags/*:refs/tags/*'
$ git fetch --no-tags --prune-tags origin
The reason it doesn’t error out when provided without --prune or its config versions is for flexibility of the configured versions, and to maintain a 1=1 mapping between what the command line flags
do, and what the configuration versions do.
```
--
Ben Denhartog
ben@sudoforge.com
On Sat, May 2, 2020, at 23:54, Jeff King wrote:
> On Sat, May 02, 2020 at 02:01:35PM -0700, Ben Denhartog wrote:
>
> > # set up the fork
> > git -C /tmp/b init
> > git -C /tmp/b remote add -f --no-tags upstream file:///tmp/a
> > ```
> >
> > You'll see the 0.0.1 tag being fetched. You can delete it all you
> > want, set the `remote.upstream.tagopt = --no-tags`, etc -- it will
> > always be pulled. This is the opposite behavior I would expect based
> > on the available documentation and discussion around the tag in the
> > mailing list.
>
> I don't see that behavior. I get:
>
> $ git -C /tmp/b remote add -f --no-tags upstream file:///tmp/a
> Updating upstream
> remote: Enumerating objects: 3, done.
> remote: Counting objects: 100% (3/3), done.
> remote: Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
> Unpacking objects: 100% (3/3), 197 bytes | 197.00 KiB/s, done.
> From file:///tmp/a
> * [new branch] master -> upstream/master
>
> Is it possible you have some other config that might be conflicting
> (e.g., extra refspecs that ask to transfer tags)? What does "git config
> --list --show-origin" say?
>
> -Peff
>
next prev parent reply other threads:[~2020-05-03 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 21:01 --no-tags doesn't appear to be working as intended Ben Denhartog
2020-05-03 6:54 ` Jeff King
2020-05-03 18:27 ` Ben Denhartog [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-02 22:20 Ben Denhartog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ecc6a46-001a-45b5-8b63-7e07f88acfb9@www.fastmail.com \
--to=ben@sudoforge.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).